Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up: Function _layout_get_all_info() (layout.module:1616) called deprecated function layout_layout_info() #6758

Open
indigoxela opened this issue Nov 21, 2024 · 3 comments

Comments

@indigoxela
Copy link
Member

indigoxela commented Nov 21, 2024

Description of the bug

This is a follow-up to #6628, where hook_layout_info() has been renamed.

There's an oversight in function _layout_get_all_info()

  if (!isset($all_info[$data_type])) {
    _layout_include_files();
    $all_info[$data_type] = $init;

    foreach (module_implements($data_type . '_info') as $module) {
      $function = $module . '_' . $data_type . '_info';// $function is layout_layout_info
      $data = $function();
      $module_path = backdrop_get_path('module', $module);
...

Steps To Reproduce

  1. Make sure, you're on the latest dev version
  2. Flush caches
  3. Go to dblog to check

Actual behavior

The function _layout_get_all_info() (layout.module:1616) called deprecated function layout_layout_info(). It will be removed in the next major release of Backdrop.

Expected behavior

Core itself shouldn't call deprecated code - deprecated by itself. 😉

Didn't dig any deeper, but I'm confident, @docwilmot will find a quick solution.

Additional information

@quicksketch quicksketch added this to the 1.29.3 milestone Nov 22, 2024
@quicksketch
Copy link
Member

Let's put this into the bug-fix milestone since it's effectively a regression caused by 1.29.2.

@indigoxela
Copy link
Member Author

it's effectively a regression caused by 1.29.2.

It's not released yet, as the change from #6628 will be part of 1.30.0, but didn't go into 1.29.

@indigoxela indigoxela modified the milestones: 1.29.3, 1.30.0 Nov 22, 2024
@quicksketch
Copy link
Member

Oh right, thank you for the clarification. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants