Fail the marathon task on any exception thrown, instead of silently s…

…wallowing them
badoo · Dec 18, 2023 · 45e6925 · 45e6925
1 parent 4928b65
commit 45e6925
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/core/src/main/kotlin/com/malinskiy/marathon/Marathon.kt b/core/src/main/kotlin/com/malinskiy/marathon/Marathon.kt
@@ -175,11 +175,10 @@ class Marathon(
         try {
             scheduler.stopAndWaitForCompletion()
             onFinish(analytics, deviceProvider, attachmentManager)
-        } catch (up: ReportGenerationException) {
-            // We don't want to catch this. This should fail the execution
-            throw up
         } catch (throwable: Throwable) {
+            // We don't want to catch these. If an exception was thrown, we should fail the execution
             log.error("Error occurred while finishing tests run", throwable)
+            throw throwable
         } finally {
             hook.uninstall()