Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2D image conversion to ignore z when dropping border #85

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix 2D image conversion to ignore z when dropping border #85

merged 1 commit into from
Dec 9, 2024

Conversation

jessicasyu
Copy link
Member

Resolves #84

@jessicasyu jessicasyu added the type: bug Something isn't working as expected label Dec 5, 2024
@jessicasyu jessicasyu requested a review from Jannetty December 5, 2024 22:12
Jannetty
Jannetty approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@Jannetty Jannetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks Jessica!

@jessicasyu jessicasyu merged commit 24dc010 into main Dec 9, 2024
6 checks passed
@jessicasyu jessicasyu deleted the fix/2d-border branch December 9, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jannetty Jannetty Jannetty approved these changes

Assignees
No one assigned
Labels
type: bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add check for 2D simulation before removing border
2 participants
@jessicasyu @Jannetty