'Show controls' button should be ticked by default

[mvl22]

By default 'Show controls' seems to be off, which seems to be an unhelpful default.

It does not seem to be possible to change this programmatically using the CKEditor JS API either :(

[bbailla2]

I haven't tested this, but I'm guessing plugin.js line 25 should grab a value from the CKEditor's configuration?

ckeditor-html5-video/html5video/plugin.js

Line 25 in 15fc6b1

var controls = '';

[jonespm]

Yeah, the pattern used in a plugin like autosave would work well. Just have a new config like html5video that can can change the defaults here.

https://github.com/w8tcha/CKEditor-AutoSave-Plugin/blob/55029859eb3ddb2c5537f99304ba782dd30880ca/autosave/plugin.js#L38

[JerryTam]

edit html5video/plugin.js

                   if (editor.config) {
                        var getConfig = function(key, defaultVal = false) {
                            if (editor.config[`html5video_${key}`] != undefined) {
                                return editor.config[`html5video_${key}`];
                            } else if (editor.config.html5video && editor.config.html5video[key] != undefined) {
                                return editor.config.html5video[key];
                            } else {
                                return defaultVal;
                            }
                        }
                        this.setData('controls', getConfig('controls'));
                        this.setData('autoplay', getConfig('autoplay', 'no'));
                        this.setData('responsive', getConfig('responsive'));
                    }

use example

global config

        config.extraPlugins = 'html5video';

	config.html5video = {
		// controls: true,
		// autoplay: 'yes', // [yes, no]
		// responsive: true,
	};

single config

            CKEDITOR.replace('dom id', {
                filebrowserImageUploadUrl: '/foo',
                filebrowserHtml5videoUploadUrl: '/bar',
                extraPlugins: 'html5video',
                html5video_controls: true,
                html5video_responsive: true,
                html5video_autoplay: 'yes',
            });