Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge incomplete fractional messages from the message assembly buffer after a timeout #787

Open
balazsracz opened this issue Feb 23, 2024 · 0 comments

Comments

@balazsracz
Copy link
Collaborator

Currently IfCan is reassembling multi-frame messages using an internal buffer which does not have a limit on the memory size. If there are partial messages coming and they never are completed, this buffer will keep growing.

We should have some eviction policy that messages which are incomplete after some period of time (say 3 seconds) elapsed since the last frame will be dropped, either silently or with an OIR to the sender.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant