You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@hunterjackson So sorry that our docs leads to misunderstandings, they're marked as optional since if you call these functions from inside application container then you don't need to pass these parameters while they're mandatory if called outside application container.
We will update our docs to fix the misunderstandings, thanks for raising this issue.
Curious as if I simply comment out the lines checking for those parameters
and raising an error if they're not there, only one of the parameters are
needed and the function I tested works fine.
On Tue, Apr 3, 2018, 11:16 PM Trong Nghia Nguyen ***@***.***> wrote:
@hunterjackson <https://github.com/hunterjackson> So sorry that our docs
leads to misunderstandings, they're marked as optional since if you call
these functions from inside application container then you don't need to
pass these parameters while they're mandatory if called outside application
container.
We will update our docs to fix the misunderstandings, thanks for raising
this issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#77 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGhwyoKjQX5V64LsBPzNjOb2-tFZT4asks5tlGUKgaJpZM4S7yr4>
.
Documentation link: https://github.com/resin-io/resin-sdk-python/blob/master/DOCUMENTATION.md#supervisor
Code that makes them both mandatory: https://github.com/resin-io/resin-sdk-python/blob/master/resin/models/supervisor.py#L39-L44
The text was updated successfully, but these errors were encountered: