Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supervisor Functions list app_id and device_uuid as optional #77

Open
hunterjackson opened this issue Mar 26, 2018 · 2 comments
Open

Supervisor Functions list app_id and device_uuid as optional #77

hunterjackson opened this issue Mar 26, 2018 · 2 comments

Comments

@hunterjackson
Copy link

Documentation link: https://github.com/resin-io/resin-sdk-python/blob/master/DOCUMENTATION.md#supervisor

Code that makes them both mandatory: https://github.com/resin-io/resin-sdk-python/blob/master/resin/models/supervisor.py#L39-L44

@nghiant2710
Copy link
Contributor

@hunterjackson So sorry that our docs leads to misunderstandings, they're marked as optional since if you call these functions from inside application container then you don't need to pass these parameters while they're mandatory if called outside application container.

We will update our docs to fix the misunderstandings, thanks for raising this issue.

@hunterjackson
Copy link
Author

hunterjackson commented Apr 4, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants