dsds

.github/actions/publish/action.yml

@@ -145,6 +145,8 @@ runs:
         echo "version=${APPLICATION_VERSION}" >> $GITHUB_OUTPUT
 
       env:
+        # ensure we sign the artifacts
+        NODE_ENV: production
         # Apple notarization
         XCODE_APP_LOADER_EMAIL: ${{ inputs.XCODE_APP_LOADER_EMAIL }}
         XCODE_APP_LOADER_PASSWORD: ${{ fromJSON(inputs.secrets).XCODE_APP_LOADER_PASSWORD }}

.github/actions/test/action.yml

@@ -64,7 +64,6 @@ runs:
       env:
         # https://www.electronjs.org/docs/latest/api/environment-variables
         ELECTRON_NO_ATTACH_CONSOLE: 'true'
-        ELECTRON_SKIP_NOTARIZATION: 'true'
 
     - name: Compress custom source
       if: runner.os != 'Windows'

forge.config.ts

@@ -21,7 +21,7 @@ every byte of data was written correctly and much more.`;
 let osxSigningConfig: any = {};
 let winSigningConfig: any = {};
 
-if (process.env.NODE_ENV !== 'development' && process.env.ELECTRON_SKIP_NOTARIZATION !== 'true') {
+if (process.env.NODE_ENV === 'production') {
   osxSigningConfig.osxSign = {
     optionsForFile: () => ({
       entitlements: './entitlements.mac.plist',
@@ -139,7 +139,7 @@ const config: ForgeConfig = {
       env: 'ETCHER_UTIL_BIN_PATH',
       path: './out/sidecar/bin/etcher-util',
       build: {
-        command: 'tsc --project tsconfig.sidecar.json && pkg out/sidecar/util/api.js -c pkg-sidecar.json --target node18 --output out/sidecar/bin/etcher-util',
+        command: 'npm run build-sidecar',
         sources: './lib/util/',
       },
       verbose: true,

package.json

@@ -14,6 +14,9 @@
     "url": "[email protected]:balena-io/etcher.git"
   },
   "scripts": {
+    "tsc": "tsc",
+    "pkg": "pkg",
+    "build-sidecar": "npm rebuild mountutils && npm run tsc -- --project tsconfig.sidecar.json && npm run pkg -- ./out/sidecar/util/api.js -c pkg-sidecar.json --target node18 --output ./out/sidecar/bin/etcher-util",
     "lint-css": "prettier --write lib/**/*.css",
     "lint-ts": "balena-lint --fix --typescript typings lib tests webpack.config.ts",
     "lint": "npm run lint-ts && npm run lint-css",

tsconfig.sidecar.json

@@ -12,7 +12,7 @@
     "moduleResolution": "Node",
     "resolveJsonModule": true,
     "isolatedModules": true,
-    "outDir": "out/sidecar"
+    "outDir": "./out/sidecar"
   },
-  "include": ["lib/util"]
+  "include": ["./lib/util"]
 }