-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update /os/v1/config endpoint for config.json migration #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cywang117
added a commit
to balena-os/os-config
that referenced
this pull request
Aug 21, 2023
This also includes the binary querying /os/v2/config instead, which has a different response format. The changes to the response format are reflected in the updated tests in this commit. See: https://balena.fibery.io/Work/Improvement/os-config-improving-the-interface-for-config.json-modification-901 See: balena-os/meta-balena#3227 See: balena-io/open-balena-api#1394 Signed-off-by: Christina Ying Wang <[email protected]> Change-type: major
cywang117
added a commit
to balena-os/os-config
that referenced
this pull request
Aug 24, 2023
This also includes the binary querying /os/v2/config instead, which has a different response format. The changes to the response format are reflected in the updated tests in this commit. See: https://balena.fibery.io/Work/Improvement/os-config-improving-the-interface-for-config.json-modification-901 See: balena-os/meta-balena#3227 See: balena-io/open-balena-api#1394 Signed-off-by: Christina Ying Wang <[email protected]> Change-type: major
cywang117
added a commit
to balena-os/os-config
that referenced
this pull request
Aug 28, 2023
This also includes the binary querying /os/v2/config instead, which has a different response format. The changes to the response format are reflected in the updated tests in this commit. See: https://balena.fibery.io/Work/Improvement/os-config-improving-the-interface-for-config.json-modification-901 See: balena-os/meta-balena#3227 See: balena-io/open-balena-api#1394 Signed-off-by: Christina Ying Wang <[email protected]> Change-type: major
cywang117
force-pushed
the
os-config-v2-endpoint
branch
from
August 29, 2023 23:45
9207685
to
906d836
Compare
joshbwlng
reviewed
Aug 30, 2023
thgreasi
reviewed
Aug 31, 2023
auto-merge was automatically disabled
September 4, 2023 22:01
Pull request was converted to draft
cywang117
force-pushed
the
os-config-v2-endpoint
branch
from
September 4, 2023 23:09
906d836
to
010bd7a
Compare
cywang117
changed the title
Add /os/v2/config endpoint for config.json migration
Update /os/v1/config endpoint for config.json migration
Sep 11, 2023
cywang117
force-pushed
the
os-config-v2-endpoint
branch
from
September 11, 2023 21:08
010bd7a
to
e7a52d2
Compare
thgreasi
reviewed
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just NITs (but note that I wasn't in the arch call).
cywang117
force-pushed
the
os-config-v2-endpoint
branch
from
September 13, 2023 21:12
e7a52d2
to
bcfb43d
Compare
cywang117
added a commit
to balena-os/os-config
that referenced
this pull request
Sep 13, 2023
The response from querying /os/v1/config has changed slightly, the changes to the response are reflected in the updated tests in this commit. See: https://balena.fibery.io/Work/Improvement/os-config-improving-the-interface-for-config.json-modification-901 See: balena-os/meta-balena#3227 See: balena-io/open-balena-api#1394 Signed-off-by: Christina Ying Wang <[email protected]> Change-type: minor
cywang117
force-pushed
the
os-config-v2-endpoint
branch
from
October 2, 2023 21:17
bcfb43d
to
db4c85c
Compare
See: https://balena.fibery.io/Work/Improvement/os-config-improving-the-interface-for-config.json-modification-901 Change-type: minor Signed-off-by: Christina Ying Wang <[email protected]>
cywang117
force-pushed
the
os-config-v2-endpoint
branch
from
October 10, 2023 18:16
db4c85c
to
572692e
Compare
@balena-ci I self-certify! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://balena.fibery.io/Work/Improvement/os-config-improving-the-interface-for-config.json-modification-901
See: https://balena.zulipchat.com/#narrow/stream/346007-balena-io.2FbalenaCloud/topic/os-config.20v2.20endpoint
Change-type: minor