Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update /os/v1/config endpoint for config.json migration #1394

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

cywang117 added a commit to balena-os/os-config that referenced this pull request Aug 21, 2023
This also includes the binary querying /os/v2/config instead,
which has a different response format. The changes to the response
format are reflected in the updated tests in this commit.

See: https://balena.fibery.io/Work/Improvement/os-config-improving-the-interface-for-config.json-modification-901
See: balena-os/meta-balena#3227
See: balena-io/open-balena-api#1394
Signed-off-by: Christina Ying Wang <[email protected]>
Change-type: major
cywang117 added a commit to balena-os/os-config that referenced this pull request Aug 24, 2023
This also includes the binary querying /os/v2/config instead,
which has a different response format. The changes to the response
format are reflected in the updated tests in this commit.

See: https://balena.fibery.io/Work/Improvement/os-config-improving-the-interface-for-config.json-modification-901
See: balena-os/meta-balena#3227
See: balena-io/open-balena-api#1394
Signed-off-by: Christina Ying Wang <[email protected]>
Change-type: major
cywang117 added a commit to balena-os/os-config that referenced this pull request Aug 28, 2023
This also includes the binary querying /os/v2/config instead,
which has a different response format. The changes to the response
format are reflected in the updated tests in this commit.

See: https://balena.fibery.io/Work/Improvement/os-config-improving-the-interface-for-config.json-modification-901
See: balena-os/meta-balena#3227
See: balena-io/open-balena-api#1394
Signed-off-by: Christina Ying Wang <[email protected]>
Change-type: major
@cywang117 cywang117 force-pushed the os-config-v2-endpoint branch from 9207685 to 906d836 Compare August 29, 2023 23:45
@cywang117 cywang117 marked this pull request as ready for review August 29, 2023 23:45
@flowzone-app flowzone-app bot enabled auto-merge August 29, 2023 23:48
src/features/os-config/index.ts Outdated Show resolved Hide resolved
src/features/os-config/index.ts Outdated Show resolved Hide resolved
@cywang117 cywang117 marked this pull request as draft September 4, 2023 22:01
auto-merge was automatically disabled September 4, 2023 22:01

Pull request was converted to draft

@cywang117 cywang117 force-pushed the os-config-v2-endpoint branch from 906d836 to 010bd7a Compare September 4, 2023 23:09
@cywang117 cywang117 changed the title Add /os/v2/config endpoint for config.json migration Update /os/v1/config endpoint for config.json migration Sep 11, 2023
@cywang117 cywang117 force-pushed the os-config-v2-endpoint branch from 010bd7a to e7a52d2 Compare September 11, 2023 21:08
@cywang117 cywang117 marked this pull request as ready for review September 11, 2023 21:10
Copy link
Member

@thgreasi thgreasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just NITs (but note that I wasn't in the arch call).

src/features/os-config/index.ts Outdated Show resolved Hide resolved
test/22_os-config.ts Outdated Show resolved Hide resolved
src/features/os-config/index.ts Outdated Show resolved Hide resolved
test/22_os-config.ts Show resolved Hide resolved
@cywang117 cywang117 force-pushed the os-config-v2-endpoint branch from e7a52d2 to bcfb43d Compare September 13, 2023 21:12
@flowzone-app flowzone-app bot enabled auto-merge September 13, 2023 21:13
cywang117 added a commit to balena-os/os-config that referenced this pull request Sep 13, 2023
The response from querying /os/v1/config has changed slightly,
the changes to the response are reflected in the updated tests
in this commit.

See: https://balena.fibery.io/Work/Improvement/os-config-improving-the-interface-for-config.json-modification-901
See: balena-os/meta-balena#3227
See: balena-io/open-balena-api#1394
Signed-off-by: Christina Ying Wang <[email protected]>
Change-type: minor
@cywang117 cywang117 force-pushed the os-config-v2-endpoint branch from bcfb43d to db4c85c Compare October 2, 2023 21:17
@cywang117 cywang117 force-pushed the os-config-v2-endpoint branch from db4c85c to 572692e Compare October 10, 2023 18:16
@cywang117
Copy link
Contributor Author

@balena-ci I self-certify!

@flowzone-app flowzone-app bot merged commit 0ccd111 into master Oct 10, 2023
46 checks passed
@flowzone-app flowzone-app bot deleted the os-config-v2-endpoint branch October 10, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants