Enforces login with auth permission #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@otaviojacobi Could you give some background on why we're adding |
Page-
reviewed
Jun 5, 2024
otaviojacobi
force-pushed
the
enforces-login-with-auth-permission
branch
from
cdf177b to
664f24e
Compare
Change-type: minor
otaviojacobi
force-pushed
the
enforces-login-with-auth-permission
branch
from
664f24e to
4e453b1
Compare
Page-
approved these changes
Jun 5, 2024
thgreasi
reviewed
Jun 5, 2024
| @@ -28,6 +29,12 @@ export const login = | |||
| if (!matches) { | |||
| throw new BadRequestError('Current password incorrect.'); | |||
| } | |||
|
|
|||
| const userPermissions = await permissions.getUserPermissions(user.id); | |||
There was a problem hiding this comment.
I think that you should be able to replace this w/ a middleware.permissionRequired('auth.credentials_login', { statusCode: 400, message: 'User not allowed to login.' }), but
- we can't do it that way if we want to only make this check after validating the user's password.
- it's not a big deal
- we atm do not support that kind of a second argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are moving towards more granular login permissions based on roles. The main advantage is that this allow for more control over different permissions, for example, users added by SAML won't be able to do
auth.credentials_login(andauth.social_service_account_loginstill to be done in balena-api). More over, this also allow for more control, for example, in the future I could see orgs configuring their users to only allow specific login methods (altough this is a stretch, the work here creates the foundation for it to be possible).