Push to open-balena-db as well as resin-db #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extracts commands into a separate script - Updates CI to Docker 17.X - Normalises pushed images to: - revision: eg. 22dd724 - branch: maintenance - semver: eg v1.5.2-5-g22dd724 Change-Type: patch
dfunckt
changed the title
brownjohnf
approved these changes
Mar 19, 2018
|
I prefer having the build script actually in the circle yaml file, but this looks fine. |
Page-
approved these changes
Mar 19, 2018
.circleci/config.yml
Outdated
| docker pull ${DOCKER_IMAGE}:${CIRCLE_BRANCH} || true | ||
| docker build --rm=false --pull --tag ${DOCKER_IMAGE}:${CIRCLE_SHA1} . | ||
| - deploy: | ||
| docker info |
There was a problem hiding this comment.
There's no need for this docker info, I think it was debug left over from where you copied this
ghost
merged commit 
ghost
removed
the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pushes built images to
open-balena-dbrepo as well as underresin-db. This is the first step towards open sourcing resin-db.There are also a few other maintenance changes:
Change-Type: patch