Add license #17
Merged
Add license #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-type: patch
Change-type: patch
dfunckt
requested review from
wrboyce,
Page-,
petrosagg,
brownjohnf,
mikesimos and
hedss
ghost
assigned 
mikesimos
approved these changes
Oct 29, 2018
wrboyce
approved these changes
Oct 29, 2018
There was a problem hiding this comment.
Looks good, although you are missing preamble from the source (the single .sh) file (and, extremely minor, the footer is still in the license). You can use this script to download the agpl3 license and add appropriate preambles.
|
@wrboyce yeah, in fact we actually need to change all repos (except VPN) to have the preamble. I'll merge this one now and handle all of them at a later point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also stops publishing to the private DockerHub repo -- cc @wrboyce
Change-type: patch