Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read/write racing issue with config.json #10

Open
majorz opened this issue Aug 23, 2018 · 1 comment
Open

Read/write racing issue with config.json #10

majorz opened this issue Aug 23, 2018 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@majorz
Copy link
Contributor

majorz commented Aug 23, 2018

During an update there is delay due to network unavailability and/or the needed time for fetching the config from the API endpoint, which causes a racing issue with other services that write to config.json. When merging data back to config.json we need to use a fresh copy of it. This will hugely minimize the chance for such a racing issue to occur. We need do add an integration test for this as well.

@majorz majorz added the bug Something isn't working label Aug 23, 2018
@majorz majorz self-assigned this Aug 23, 2018
@pritamghanghas
Copy link

what is the racing issue causing? A corrupt json?
We are also facing corrupt json issues but those look like filesystem corruption issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants