Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header name mapping for record fields and add util functions for conversions #2153

Merged
merged 15 commits into from
Sep 23, 2024

Conversation

TharmiganK
Copy link
Contributor

@TharmiganK TharmiganK commented Sep 20, 2024

Purpose

$Subject

Fixes: ballerina-platform/ballerina-library#7018
Fixes: ballerina-platform/ballerina-library#7019

Examples

Refer to the above attached issue for examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility
  • Checked the impact on OpenAPI generation - Added via this PR

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 98.11321% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.32%. Comparing base (b222df2) to head (3b117aa).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
...lerina/stdlib/http/api/nativeimpl/ExternUtils.java 96.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2153      +/-   ##
============================================
- Coverage     80.42%   80.32%   -0.11%     
- Complexity        0      669     +669     
============================================
  Files           366      408      +42     
  Lines         20738    22988    +2250     
  Branches       4841     5271     +430     
============================================
+ Hits          16679    18465    +1786     
- Misses         3123     3385     +262     
- Partials        936     1138     +202     
Flag Coverage Δ
80.32% <98.11%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TharmiganK TharmiganK marked this pull request as ready for review September 23, 2024 05:31
daneshk
daneshk previously approved these changes Sep 23, 2024
Copy link
Member

@daneshk daneshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@TharmiganK TharmiganK merged commit 6004c86 into master Sep 23, 2024
8 checks passed
@TharmiganK TharmiganK deleted the header-name branch September 23, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants