Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some Java classes proper utilities #40

Conversation

vil02
Copy link
Contributor

@vil02 vil02 commented Oct 12, 2023

Purpose

Closes ballerina-platform/ballerina-library#4919.

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

Made the design cleaner by marking Java classes as `final`
and explicitly declaring their default constructors as `private`.
This change makes the code coverage reports more accurate.
Fixes #4919.
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (295f090) 86.43% compared to head (1381636) 84.34%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #40      +/-   ##
============================================
- Coverage     86.43%   84.34%   -2.09%     
- Complexity       92      169      +77     
============================================
  Files            18       28      +10     
  Lines           597      888     +291     
  Branches         85      147      +62     
============================================
+ Hits            516      749     +233     
- Misses           70       92      +22     
- Partials         11       47      +36     
Files Coverage Δ
...io/ballerina/stdlib/mqtt/compiler/PluginUtils.java 70.83% <ø> (ø)
...io/ballerina/stdlib/mqtt/caller/CallerActions.java 86.66% <ø> (+2.79%) ⬆️
...io/ballerina/stdlib/mqtt/client/ClientActions.java 86.53% <ø> (+0.82%) ⬆️
...allerina/stdlib/mqtt/listener/ListenerActions.java 84.31% <ø> (+1.62%) ⬆️
...va/io/ballerina/stdlib/mqtt/utils/ModuleUtils.java 100.00% <ø> (ø)
.../io/ballerina/stdlib/mqtt/utils/MqttConstants.java 100.00% <ø> (+3.33%) ⬆️
...java/io/ballerina/stdlib/mqtt/utils/MqttUtils.java 87.50% <ø> (+0.57%) ⬆️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThisaruGuruge ThisaruGuruge merged commit 65dd908 into ballerina-platform:main Oct 13, 2023
@vil02 vil02 deleted the 4919_make_some_java_classes_proper_utilities branch October 13, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make some of the Java classes in module-mqtt proper utility classes
2 participants