Add configuration for enabling observability logs #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NipunaMadhushan
requested review from
chathurace and
keizer619
as code owners
chathurace
reviewed
Nov 1, 2024
ballerina/commons.bal
Outdated
| @@ -23,6 +23,7 @@ configurable boolean metricsEnabled = false; | |||
| configurable string metricsReporter = ""; | |||
| configurable boolean tracingEnabled = false; | |||
| configurable string tracingProvider = ""; | |||
| configurable boolean observabilityLogsEnabled = false; | |||
There was a problem hiding this comment.
shall we change this to metricsLogsEnabled
There was a problem hiding this comment.
@chathurace Addressed suggestions
chathurace
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We need to add observability logs to provide response time in seconds for each response. This should be configured in the runtime. Therefore we need to add a configuration in the observe module.
Fixes ballerina-platform/ballerina-lang#43478
Examples
Checklist