Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple the flatten from the sanitize sub command #1775

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Decouple the flatten from the sanitize sub command #1775

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bd54930
Decouple flatten from Sanitize command
lnash94 Sep 25, 2024
b497212
Separate to different functions
lnash94 Sep 25, 2024
7291142
Fix review suggestions
lnash94 Sep 26, 2024
1dc6290
Merge branch 'master' into dicouple_flatten_from_sanitize
lnash94 Sep 27, 2024
b30ae39
Update with the review suggestions
lnash94 Oct 3, 2024
0e8b984
Merge branch 'dicouple_flatten_from_sanitize' of https://github.com/l…
lnash94 Oct 3, 2024
8a492e0
Merge branch 'master' into dicouple_flatten_from_sanitize
lnash94 Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openapi-cli/src/main/java/io/ballerina/openapi/cmd/Sanitize.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public String getDefaultFileName() {
@Override
public Optional<OpenAPI> generate(String openAPIFileContent) {
Optional<OpenAPI> filteredOpenAPI = getFilteredOpenAPI(openAPIFileContent);
return filteredOpenAPI.flatMap(this::getFlattenOpenAPI).flatMap(this::sanitizeOpenAPI);
return filteredOpenAPI.flatMap(this::sanitizeOpenAPI);
lnash94 marked this conversation as resolved.
Show resolved Hide resolved
}

private Optional<OpenAPI> sanitizeOpenAPI(OpenAPI openAPI) {
Expand Down
4 changes: 1 addition & 3 deletions openapi-cli/src/main/resources/cli-help/ballerina-openapi-sanitize.help
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@ SYNOPSIS

DESCRIPTION
Sanitize the OpenAPI contract file according to the best naming
practices of Ballerina. The OpenAPI contract is flatten and the type
schema names are made Ballerina friendly. The Ballerina name
extensions are added to the schemas which can not be modified
practices of Ballerina. The Ballerina name extensions are added to the schemas which can not be modified
lnash94 marked this conversation as resolved.
Show resolved Hide resolved
directly.


Expand Down
Loading
Loading