Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add vault sync connector #48

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Feature: Add vault sync connector #48

merged 3 commits into from
Jan 18, 2024

Conversation

gabheadz
Copy link
Contributor

  • Added vault sync connector
  • Code refactor to extract vault common abstractions to be used by two connector flavours.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
88.8% Coverage on New Code
0.6% Duplication on New Code

See analysis details on SonarCloud

@juancgalvis juancgalvis merged commit e8c1b78 into master Jan 18, 2024
7 of 9 checks passed
@juancgalvis juancgalvis deleted the feature/vault-sync-connector branch January 18, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juancgalvis juancgalvis juancgalvis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabheadz @juancgalvis