Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py vs pyproject.toml #137

Open
jared321 opened this issue Aug 29, 2024 · 1 comment
Open

setup.py vs pyproject.toml #137

jared321 opened this issue Aug 29, 2024 · 1 comment
Assignees

Comments

@jared321
Copy link
Contributor

The package currently has both a pyproject.toml file and a setup.py file in place. The former contains the majority of the package specification; the latter, content for converting a single .pyx file to a Python module in the package.

According to the Cython docs, using setup.py is the recommended method. Evaluate the possibility of using just or the other but not both.

Note that the source distribution and binary wheels presently contain files such as documentation, example code, GH actions, etc. Is this as intended or can we remove those?

@mosesyhc
Copy link
Member

I believe we should remove non-codebase files from the source distribution and binary wheels.

FWIW, at one point __init__.py is included in tests/ and will take up the tests namespace. Those were removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants