Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GenericStringKernel.element_wise_kernel redundancy? #2

Open
rfriedman22 opened this issue Mar 27, 2019 · 0 comments
Open

GenericStringKernel.element_wise_kernel redundancy? #2

rfriedman22 opened this issue Mar 27, 2019 · 0 comments
Labels
question Further information is requested

Comments

@rfriedman22
Copy link
Member

In preimage.kernels.generic_string, there are two functions called element_wise_kernel. One is its own function, the other is a method of the GenericStringKernel class. This feels redundant, especially since they do similar things. Need to figure out if it's actually redundant and deal with things appropriately.
@rfriedman22 rfriedman22 added the question Further information is requested label Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rfriedman22