Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The data-barba-prevent attribute doesn't work on a self transition #700

Open
Tracked by #703
xavierfoucrier opened this issue Mar 15, 2023 · 1 comment
Open
Tracked by #703
Assignees
Labels
@barba/core @barba/core plugin bug bug to fix
Milestone

Comments

@xavierfoucrier
Copy link
Member

When using a prevent data attribute on a link that run a self transition, the transition is not prevented.

Note that the prevent strategy work as expected, so currently you can prevent the transition from running by using event.preventDefault() followed by event.stopPropagation() inside the prevent callback.

@xavierfoucrier xavierfoucrier added bug bug to fix @barba/core @barba/core plugin labels Mar 15, 2023
@xavierfoucrier xavierfoucrier added this to the barba@next milestone May 10, 2023
@xavierfoucrier xavierfoucrier self-assigned this Jul 30, 2023
@xavierfoucrier xavierfoucrier mentioned this issue Jul 31, 2023
15 tasks
@xavierfoucrier xavierfoucrier changed the title Prevent data attribute doesn't work on a self transition The data-barba-prevent attribute doesn't work on a self transition Mar 13, 2024
@xavierfoucrier
Copy link
Member Author

Re-introduced by 6d35aa4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@barba/core @barba/core plugin bug bug to fix
Projects
None yet
Development

No branches or pull requests

1 participant