Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barba breaks when route contains colon and number #750

Open
psntr opened this issue Aug 13, 2024 · 3 comments
Open

Barba breaks when route contains colon and number #750

psntr opened this issue Aug 13, 2024 · 3 comments
Labels
@barba/core @barba/core plugin bug bug to fix

Comments

@psntr
Copy link

psntr commented Aug 13, 2024

What version are you using?

v.2.10.3

What package are you using?

@barba/core

Describe your issue

This issue happens already in previous version where I didn't fix with Barba but change my routing to prevent the using colon and number in my URL.

The reason there is colon and number in my URL, is because I'm using Kirby CMS, and when using params to filter via routing, they append the terms in the URL like so:
www.mywebsite.com/blog/tag:2013

Every time there is a colon followed by a number, barba stop working so the page transition do not work and next subsequent page transition result in also on the default "hard" transition.

I tried to use barba.go(), which works for the first transition but then again, the next one doesn't work. This only occurs when there is a colon and a number in the URL. Meaning this works www.mywebsite.com/blog/tag:any.

Weirdly enough, this only occurs on my production server regardless of the hosting company…

@psntr psntr added the bug bug to fix label Aug 13, 2024
@xavierfoucrier
Copy link
Member

Hello @psntr 👋

Thanks for opening an issue!

I already worked with Kirby CMS on a project where we had BarbaJS as a dependency, but all was fine.

What version of the CMS are you using?
Do you use @barba/router on your project?

Waiting for your feedback 👀

@psntr
Copy link
Author

psntr commented Aug 15, 2024

Hi thanks for the suggestion!

I never used @barba/router so I'll give it a try and let you know. Just to clear out any doubt, BarbaJS works fine with Kirby CMS, it's just some isolated case when using specific terminology as such as /tag:2013 in the URL and online only.

At the moment I bypassed the default URL construction from /tag:2013 to /tag/2013 but will definitely check the router plugin.

@xavierfoucrier
Copy link
Member

Thanks for the feedback @psntr 👍

Understood for isolated cases, but bypassing is not a solution as you said, especially if you want to keep the CMS up to date and deal with new releases as well.

Let me know if you end make it work with @barba/router 😉

@xavierfoucrier xavierfoucrier added the @barba/core @barba/core plugin label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@barba/core @barba/core plugin bug bug to fix
Projects
None yet
Development

No branches or pull requests

2 participants