Skip to content

Commit 95fc00a

Browse files
committed
Merge branch 'libnvdimm-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm
Pull memremap fix from Dan Williams: "The new memremap() api introduced in the 4.3 cycle to unify/replace ioremap_cache() and ioremap_wt() is mishandling the highmem case. This patch has received a build success notification from a 0day-kbuild-robot run and has received an ack from Ard" From the commit message: "The impact of this bug is low for now since the pmem driver is the only user of memremap(), but this is important to fix before more conversions to memremap arrive in 4.4" * 'libnvdimm-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm: memremap: fix highmem support
2 parents ca04d39 + 182475b commit 95fc00a

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

kernel/memremap.c

+12-2
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,16 @@ __weak void __iomem *ioremap_cache(resource_size_t offset, unsigned long size)
2424
}
2525
#endif
2626

27+
static void *try_ram_remap(resource_size_t offset, size_t size)
28+
{
29+
struct page *page = pfn_to_page(offset >> PAGE_SHIFT);
30+
31+
/* In the simple case just return the existing linear address */
32+
if (!PageHighMem(page))
33+
return __va(offset);
34+
return NULL; /* fallback to ioremap_cache */
35+
}
36+
2737
/**
2838
* memremap() - remap an iomem_resource as cacheable memory
2939
* @offset: iomem resource start address
@@ -66,8 +76,8 @@ void *memremap(resource_size_t offset, size_t size, unsigned long flags)
6676
* the requested range is potentially in "System RAM"
6777
*/
6878
if (is_ram == REGION_INTERSECTS)
69-
addr = __va(offset);
70-
else
79+
addr = try_ram_remap(offset, size);
80+
if (!addr)
7181
addr = ioremap_cache(offset, size);
7282
}
7383

0 commit comments

Comments
 (0)