Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback after first test #30

Open
zonofthor opened this issue May 10, 2021 · 0 comments
Open

Feedback after first test #30

zonofthor opened this issue May 10, 2021 · 0 comments

Comments

@zonofthor
Copy link

zonofthor commented May 10, 2021

Just a raw feedback after 2 hours spent on testing component. Promising but fixes needed (imho).

  1. Options cannot be passed as readable meaning they are prone to mutation. A no no since we want functional coding style.
  2. No way to render icon in label (only allows string type).
  3. onOptionChange is documented as
onOptionChange(data: any) => void - executed after an option is selected or removed

is that really correct "or option removed" - the options list should not be mutable?
4. I found this lib when trying to find a minimalistic library with first class support for styled-components. A little disappointed, having to edit themeProvider as object and even then it is quite difficult to get to some styling properties, e.g. I want to reduce focused border width.
5. Cannot find a way to support cursor: pointer over control.
6. I see no possibility to hide "select options" text inside empy select
[edit: set placeholder=""] - hackish though

Just my quick tidbits. Good work, keep it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant