memory leak audit

[bookshelfdave]

Messages:

• riak_get
• riak_delete
• riak_ping
• riak_put
• riak_2index
• riak_get_bucketprops
• riak_mapreduce
• riak_search
• riak_get_clientid
• riak_serverinfo
• riak_error
• riak_listbuckets
• riak_set_bucketprops
• riak_listkeys
• riak_reset_bucketprops
• riak_set_clientid

General:

• riak_object
• riak_binary
• riak_connection
• riak_log_config
• riak_types
• riak
• riak_bucketprops
• riak_error
• riak_messages
• riak_operation
• riak_async
• riak_config
• riak_log
• riak_network

[hazen]

Is this a hand job or did you have an automated tool in mind?

[bookshelfdave]

🐟

[bookshelfdave]

I have a couple ideas, maybe we can discuss tomorrow. I liked @bkerley's idea to check Valgrind output automatically. As a first pass, we should check for riak_free's vs riak_binary_free's.

[hazen]

Yes, I also have a couple of ideas. We should figure out what we want to run Valgrind on, too.

[bookshelfdave]

See: #59

[bookshelfdave]

@javajolt I don't see where operation specific requests are being freed outside of riak_operation_free .

For example, what takes care of freeing this binary?
https://github.com/basho/riak-c-client/blob/develop/src/internal/messages/riak_set_clientid-internal.h#L26

[bookshelfdave]

Messages with custom requests:

• set client id
• set bucketprops
• get bucketprops
• reset bucketprops