Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partly-cloudy line icons use open cloud #30

Open
marcelstoer opened this issue May 29, 2023 · 4 comments
Open

Partly-cloudy line icons use open cloud #30

marcelstoer opened this issue May 29, 2023 · 4 comments
Assignees
Milestone

Comments

@marcelstoer
Copy link

marcelstoer commented May 29, 2023

The partly-cloudy line icons use a cloud symbol that is not closed at the bottom i.e. like those for the rain/hail/etc. clouds.

Examples:

The ones displayed at https://basmilius.github.io/weather-icons/index-line.html, however, don't have this bug.

@DadiBit
Copy link

DadiBit commented Jun 17, 2023

I had noticed the same issue in the past, and I believe this is due to the fact that the node script reduces the svg size by removing also some closing tags, which, I believe, should work fine on browser, but on android (for example) it just breaks the last element.

@basmilius
Copy link
Owner

basmilius commented Jun 30, 2024

Hi, sorry for the late answer. Do you mean that the first column in the screenshot should have a closed cloud? Currently working on v3 and I took over the open variant of v2, but I'm open to change it.

image

@basmilius basmilius self-assigned this Jun 30, 2024
@basmilius basmilius added this to the v3.0 milestone Jun 30, 2024
@marcelstoer
Copy link
Author

Do you mean that the first column in the screenshot should have a closed cloud?

Yes, I think that's what I meant. They look really odd to me. I feel that unless there's precipitation the cloud icon should be closed.

@basmilius
Copy link
Owner

@marcelstoer Thanks for the clarification. I agree :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants