Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature for reducing the brightness of lights during the daytime #1075

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add feature for reducing the brightness of lights during the daytime #1075

wants to merge 2 commits into from

Conversation

haasn
Copy link

@haasn haasn commented Dec 1, 2024

Ideally, we would tie this to something like a Lux sensor input, but this is the next best thing I could easily implement.

Closes: #1074

Note

I gave this implementation a try, but I'm not really sure how to test this app as there were no build/test instructions included. I'm submitting it here in the hopes that you can help me test it out locally before we merge it.

@haasn haasn requested a review from basnijholt as a code owner December 1, 2024 21:10
@haasn haasn force-pushed the reduce_daytime_brightness branch from 0f4af00 to c0fff83 Compare December 1, 2024 21:11
@haasn
Add feature for reducing the brightness of lights during the daytime
fed965a 
Ideally, we would tie this to something like a Lux sensor input, but this is
the next best thing I could easily implement.

Closes: basnijholt#1074
@haasn haasn force-pushed the reduce_daytime_brightness branch from d834a0c to fed965a Compare December 1, 2024 21:11
@haasn
Copy link
Author

haasn commented Dec 1, 2024

Update: I tried testing it locally but got:

λ docker run -v $(pwd):/app basnijholt/adaptive-lighting:latest
============================= test session starts ==============================
platform linux -- Python 3.12.7, pytest-8.3.3, pluggy-1.5.0 -- /usr/local/bin/python3
cachedir: .pytest_cache
rootdir: /core
configfile: pyproject.toml
plugins: requests-mock-1.12.1, pytest_freezer-0.4.8, cov-6.0.0, xdist-3.6.1, asyncio-0.24.0, respx-0.21.1, sugar-1.0.0, aiohttp-1.0.5, github-actions-annotate-failures-0.2.0, syrupy-4.7.2, flaky-3.8.1, picked-0.5.0, unordered-0.6.1, timeout-2.3.1, socket-0.7.0, anyio-4.6.2.post1
asyncio: mode=Mode.AUTO, default_loop_scope=function
timeout: 9.0s
timeout method: signal
timeout func_only: False
collecting ... collected 0 items

============================ no tests ran in 0.06s =============================
ERROR: file or directory not found: tests/components/adaptive_lighting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basnijholt basnijholt Awaiting requested review from basnijholt basnijholt is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decrease brightness during daylight?
1 participant
@haasn