Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Adaptive Lighting should be inactive when the light is activated via brightness #581

Closed
j3mu5 opened this issue Apr 26, 2023 · 6 comments

Comments

@j3mu5
Copy link

j3mu5 commented Apr 26, 2023

Hello dear community,

I am observing an undesirable behaviour. If I set a switched-off light in Homeassistant directly to a certain brightness in the context menu of the frontend, this is overwritten by Adaptive Lighting.

I would therefore like to see the following behaviour, if possible:

  • Adaptive Lighting should become active when the light is switched on.
  • Adaptive Lighting should not be activated when a certain brightness is set, which switches the light on.
@th3w1zard1
Copy link
Collaborator

th3w1zard1 commented May 10, 2023

See the V2 Roadmap for the main thread. This has been requested many many times already.
The short is there isn't a good way to do this as the whole integration relies on the second light.turn_on being the main trigger for manual detection. Also some lights pass brightness/color data to the ha event bus and I haven't figured out a way to distinguish these either. You can see #528 for a rough implementation of the feature, feel free to test it out and see if it works the way you'd like.

tldr, if you want to turn a light manually from off->on with AL, either call light.turn_on twice: once to turn the light on and second to set the target brightness/color, or call adaptive_lighting.set_manual_mode in your script. HA makes it very easy to do both of these and should also work with scenes. If you want to do this in the frontend with the brightness slider, just turn it on first then set the brightness.

@efenner
Copy link

efenner commented Jun 26, 2023

I have this same issue.

@th3w1zard1, you mention that this should work with scenes. Do you have any advice on that? When I apply a scene, even if I turn off the main adapt brightness toggle in the scene, the lights that are turned on by the scene that were previously off get adapted, breaking the scene.

@basnijholt
Copy link
Owner

I am implementing an option adapt_only_on_bare_turn_on which instantly triggers manual_control when turning on with brightness or color in PR #709.

Enabling this will make sure AL doesn't take over when setting a scene.

@basnijholt
Copy link
Owner

This is now in the latest beta release. Looking forward to your feedback.

@j3mu5
Copy link
Author

j3mu5 commented Aug 7, 2023

This is now in the latest beta release. Looking forward to your feedback.

@basnijholt
I just tested it - it works very well for me and exactly as desired: when setting the brightness or colour temperature directly, AL takes no action.
When switching on, AL sets brightness and colour temperature as desired.
Many thanks!

@basnijholt
Copy link
Owner

Thanks a lot for getting back to me! Glad you like it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants