Improve release workflow #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the release process successfully ran but did not result in a new release getting published, JuliaRegistrator should not be notified. This was a situation that was unlikely to happen in this repository due to its feature branch/development/main workflow, but it would have triggered incorrectly otherwise.
…egistrator In most scenarios the `main` branch is equivalent to the generated tag. However, when signing commits the tag will be a unique object that can be referenced instead. The tag will also be more stable/less likely to change during the time the registration process runs, which in general is likely not an issue but it does not hurt to guard against.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #59 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 5 5
Lines 147 147
=============================================
Hits 147 147 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor improvements to the release workflow. Previously it was possible to trigger
JuliaRegistratorfor workflow runs that did not end up resulting in a release (which wasn't a problem due to the workflow followed by this project) and the branch passed toJuliaRegistratorwas not as strict as it could be which could cause potential issues in rare cases.