Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erreur on sftp phpseclib #108

Open
mmeurisse-nacon opened this issue Mar 27, 2023 · 0 comments
Open

Erreur on sftp phpseclib #108

mmeurisse-nacon opened this issue Mar 27, 2023 · 0 comments

Comments

@mmeurisse-nacon
Copy link

Hello,

We have an error with the override Magento and compatibility with 2.4.5

In Bazaarvoice module :
/** * Fixes Magento 2.1 phpseclib notice. * * @param $filename * @param $source * @param null $mode * * @return mixed */ public function write($filename, $source, $mode = null) { $mode = is_readable($source) ? \phpseclib\Net\SFTP::SOURCE_LOCAL_FILE : \phpseclib\Net\SFTP::SOURCE_STRING; return $this->_connection->put($filename, $source, $mode); }

In Magento 2.4.5 :
/** * Write a file * * @param string $filename * @param string $source string data or local file name * @param int $mode ignored parameter * @return bool */ public function write($filename, $source, $mode = null) { $mode = is_readable($source) ? \phpseclib3\Net\SFTP::SOURCE_LOCAL_FILE : \phpseclib3\Net\SFTP::SOURCE_STRING; return $this->_connection->put($filename, $source, $mode); }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant