Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property declared dynamically, this is deprecated starting from PHP 8.2 #114

Open
jan-jagla-accenture opened this issue Aug 10, 2023 · 2 comments

Comments

@jan-jagla-accenture
Copy link

$this->_moduleList = $moduleList;

@jan-jagla-accenture
Copy link
Author

PR: #115

@bonllavier
Copy link

Hi team, we are in the process of migrating our Adobe Commerce Cloud application to PHP 8.2, and we have encountered several deprecation warnings related to the Bazaarvoice module: https://commercemarketplace.adobe.com/bazaarvoice-bazaarvoice-magento2-ext.html#product.info.details.release_notes

"name": "bazaarvoice/bazaarvoice-magento2-ext",
"description": "Bazaarvoice Magento 2 Integration Extension.",
"type": "magento2-module",
"version": "9.1.8-p1"

We would like your assistance in confirming whether your development team is also observing these deprecation warnings. If our findings are accurate, the module may not be fully compatible with PHP 8.2 due to the following issues:
Identified Issues
Class: vendor/bazaarvoice/bazaarvoice-magento2-ext/Model/BVSEOSDK/Base.php
Property bv_config: This property is not declared as private, protected, or public, which triggers a Deprecated warning in PHP 8.2.

Image

Property seo_url: This property is not explicitly declared.

Image

Properties start_time and response_time: These properties are not explicitly declared in the class.

Image

Image

Class: vendor/bazaarvoice/bazaarvoice-magento2-ext/Model/BVSEOSDK/BV.php
      
Property reviews: Declared dynamically as $this->reviews = new Reviews($this->config); but not explicitly declared in the class.

Image

Property questions: Declared dynamically but not explicitly declared.
Property stories: Declared dynamically but not explicitly declared.
Property spotlights: Declared dynamically but not explicitly declared.
Property sellerratings: Declared dynamically but not explicitly declared.
Property SEO: Declared dynamically as $this->SEO = $this->reviews; but not explicitly declared.
These are the issues we’ve identified so far. We are eager to work with you to address these warnings, as our company aims to migrate to PHP 8.2 while continuing to use this module.
Your assistance in reviewing this report and providing guidance would be greatly appreciated. Please let us know if there are any updates or fixes planned to address these deprecation warnings.
Thank you for your time and support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants