Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable header inclusion check #24926

Open
froody opened this issue Jan 15, 2025 · 0 comments
Open

Add option to disable header inclusion check #24926

froody opened this issue Jan 15, 2025 · 0 comments

Comments

@froody
Copy link

froody commented Jan 15, 2025

Description of the feature request:

In my CI environment, I see builds randomly fail with errors like this (with protobuf-29.3 imported via MODULE.bazel).

this rule is missing dependency declarations for the following files included by 'src/google/protobuf/any_lite.cc':
  'bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/protobuf~/src/google/protobuf/_virtual_includes/protobuf_lite/google/protobuf/port.h'

The randomness of this error plus the need to clean the bazel cache (which doesn't always make the error go away) wastes countless hours of time. I would love to have a flag like --incompatible-ignore-header-checks which made these errors non-fatal

Which category does this issue belong to?

C++ Rules

What underlying problem are you trying to solve with this feature?

Builds failing due to false positives from header inclusion checks

Which operating system are you running Bazel on?

Ubuntu 22.04

What is the output of bazel info release?

7.4.0

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

<private repo>

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants