Consistently thread extra target constraints around #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
force-pushed
the
custom-toolchain-constraints
branch
3 times, most recently
from
540f196
to
86c4164
Compare
Previously we were sometimes falling back to default values rather than passing through the user-supplied value.
illicitonion
force-pushed
the
custom-toolchain-constraints
branch
from
86c4164
to
720e707
Compare
illicitonion
changed the title
UebelAndre
approved these changes
Sep 3, 2024
illicitonion
added a commit
to illicitonion/rules_py
that referenced
this pull request
Oct 22, 2024
* Bump rules_rust to pull in bazelbuild/rules_rust#2829 * Mark the default non-musl linux toolchain as incompatible, so musl is forced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for selecting non-default toolchains where the exec triple matches the target triple.
This is tested by enabling the musl static linking tests on the Linux host platform. Before this PR, the test would fail because the -gnu rather than -musl rust toolchain would end up getting selected. Now, everything works.
Fixes #2726