add a Source::parse arm for sparse repos (keeping it in the scheme). … #2950

sthornington · 2024-10-19T22:51:21Z

Proc macro resolution wasn't working properly for sparse repos. This fixes #2938.

google-cla · 2024-10-19T22:51:25Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

sthornington · 2024-10-19T22:51:59Z

I wrote a test for it, but was unable to run it - cargo test seemed to want some runfiles stuff and looking at that in crates.io lead me to believe that these things are not able to be tested from within cargo.

illicitonion

LGTM, thanks so much!

crate_universe/src/metadata/cargo_tree_resolver.rs

sthornington · 2024-10-20T17:21:20Z

Thanks, let me know if there is anything else for me to do to get this merged!

sthornington · 2024-10-22T18:18:05Z

Thanks everyone for getting this in. Can I ask for a point release which includes this, or when is 0.53.1 otherwise planned? Or can I do start it myself? Thanks again.

add a Source::parse arm for sparse repos (keeping it in the scheme). f…

709aa10

…ixes bazelbuild#2938

illicitonion approved these changes Oct 20, 2024

View reviewed changes

crate_universe/src/metadata/cargo_tree_resolver.rs Outdated Show resolved Hide resolved

Update crate_universe/src/metadata/cargo_tree_resolver.rs

d1c9ab0

illicitonion enabled auto-merge October 20, 2024 15:54