Add per-target link flags in the right place #2963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
force-pushed
the
add-link-args-after-not-before
branch
from
dcf287b
to
3e36329
Compare
Previously we were adding these early on in the link args. This was a bug - if some transitive dep foo has a linkopt of `-lbar`, the `-lbar` needs to be later in the link args list than `-lfoo`. Rather than arbitrarily adding them early on and hoping things work, this adds the args for each library just after we add a dependency on that library.
illicitonion
force-pushed
the
add-link-args-after-not-before
branch
from
3e36329
to
92b6ce8
Compare
UebelAndre
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were adding these early on in the link args.
This was a bug - if some transitive dep foo has a linkopt of
-lbar, the-lbarneeds to be later in the link args list than-lfoo.Rather than arbitrarily adding them early on and hoping things work, this adds the args for each library just after we add a dependency on that library.