-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit processing when using pixels-per-second #165
Comments
I am creating a json data file and only need a specific piece of my whole audio file as waveform. |
I think this should be allowed, i.e., set As a workaround, you can set the |
It would also be nice to automatically calculate the end from the width. |
Hey Chris, I tried your suggested workaround. It does work, if I output a PNG file. The image looks correct and does fit the audio. |
Ah, sorry, I should have checked that would actually work before suggesting it. The options are handled differently for creating images vs creating data files, hence the discrepancy - for historical reasons, as we only needed full duration data files, whereas images could be any period within the audio. |
output as image for display with |
Ok, I understand. Unfortunately, I am not a CPP Developer, so I am unable to contribute here. But is there a chance, you and your contributors could implement that feature, that enables me to create Waveform JSON Files, the same way as it is possible for PNG Images respecting --start and --end arguments? I can create a dedicated Issue here, if that helps. Otherwise I will find a way to workaround this limitation by using an already shortened WAV File. |
Well, it's just me in my spare time really - but yes. There's no need to create an issue. |
I'm going to look at this together with #157, as they're related. |
When using
pixels-per-second
, one cannot add--end
- understandable, since it is redundant to--width
then. But unfortunately,--end
is the only flag that limits the time of audio that is processed, so that even on a shortwidth
, long audio files take a long time to process withpixels-per-second
. Through a simple division this should be limited internally :)The text was updated successfully, but these errors were encountered: