Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for writing to S3 stores #45

Closed
pont-us opened this issue Jun 16, 2021 · 2 comments
Closed

Add unit tests for writing to S3 stores #45

pont-us opened this issue Jun 16, 2021 · 2 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@pont-us
Copy link
Member

pont-us commented Jun 16, 2021

At present, there are only a couple of very trivial unit tests for S3 access (checking behaviour with invalid parameters). We should add more thorough tests for writing to S3 stores, probably using the moto library for mocks.

@pont-us pont-us added the enhancement New feature or request label Jun 16, 2021
@forman
Copy link
Member

forman commented Jun 16, 2021

Instead of adding new unit tests, I'd prefer we get rid of any s3-specific code. We can do this by relying entirely on the fsspec package and auto-configuration through keyword injection from config YAML. Finally we have less code and need to test.

@pont-us I'd therefore like to add the "wontfix" label and close this one in favor of #46.

@pont-us pont-us added the wontfix This will not be worked on label Jun 16, 2021
@pont-us pont-us closed this as completed Jun 16, 2021
@pont-us
Copy link
Member Author

pont-us commented Jun 16, 2021

@pont-us I'd therefore like to add the "wontfix" label and close this one in favor of #46.

Agreed and done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants