Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite workbench.colorCustomizations #12

Open
ciberger opened this issue Jul 3, 2020 · 1 comment
Open

Overwrite workbench.colorCustomizations #12

ciberger opened this issue Jul 3, 2020 · 1 comment

Comments

@ciberger
Copy link

ciberger commented Jul 3, 2020

Hi!, Thanks for developing this theme 🙌

Could it be possible to somehow overwrite a colour property from settings.json? As you can see in the image the colours for the autocomplete popup are barely visible. While researching online how to fix it I figure it out that you can configure it, however it doesn't seem to work with the theme activated.

Any help is welcome 👍

image

Resources:
https://stackoverflow.com/questions/43402855/vscode-customize-theme-color-for-selected-item-in-autocomplete-popup
https://stackoverflow.com/questions/54503289/vscode-changing-colours-inside-intellisense
https://code.visualstudio.com/api/references/theme-color#editor-widget-colors

@bceskavich
Copy link
Owner

Hi @ciberger! So, this is interesting. I tried reproducing something similar to what you're seeing...and I couldn't. Autocomplete text matches are highlighted in cyan (which is the intention). For example:

Screenshot 2020-08-06 08 08 33

That said, the theme as it stands today doesn't configure all of the editorSuggestWidget.* color options. So this feels like it might be a difference b/t VS Code version or OS.

I'll work on a patch to try to fix this in the theme's settings. Could you share your current OS and VS Code version so I might try to reproduce on my end. For reference, I'm running:

  • VS Code 1.47.3
  • macOS 10.14.5 (Mojave)
  • 2018 MBP 15"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants