Updated general tokens to match original vscode dracula #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @kelvin-mai, thanks for the PR. It looks like you have some conflicts that need resolution after the latest release. Part of the reason I originally forked Dracula was that I wanted to change some of the coloring and styling conventions in the original theme. This PR has a number of changes, many of which seem at first glance to be things I purposefully changed. I get that this comes down to personal preference, but when I first put this theme together I didn't even think anyone else would use it! It would be helpful if you could list out the specific changes you want to make, and maybe provide some before and after screenshots. I might be open to some of them. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.