Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Null check operator used on a null value; in PaddedBlockCipherImpl.process #253

Open
SalatielMG opened this issue Feb 9, 2025 · 2 comments

Comments

@SalatielMG
Copy link

Dear pointycastle team,

I am using the PaddedBlockCipherImpl class from your library and have encountered an issue when using the "process" function. I receive the following error:

Null check operator used on a null value

After reviewing the code, I identified that the issue is due to the lack of null safety checks on lines 52, 53, 56, and 86. I have created a new branch locally with a proposed solution for this problem, ensuring the necessary null checks are implemented. However, I do not have permissions to push this branch to the repository.

I would greatly appreciate it if you could review the email ("Request for Permission to Create a New Branch in pc-dart for Null Safety Issue Fix") I sent requesting permissions so that I can push the changes and subsequently create a PR, which you might consider for integration or improvement in a future release of the library.

Thank you for your attention and for the excellent work you do with pointycastle.

Best regards, Salatiel Montero.

@Ephenodrom
Copy link
Contributor

@SalatielMG
Hello,
I think the best would be, that you provide a PR. Once the PR is ready and looks good, I will merge the PR. I am currently checking all open PRs and issues and try to get as many done as possible and then release a new version on pub.dev.

@SalatielMG
Copy link
Author

Hello, thank you.
Thanks @Ephenodrom

I have created the following PR 254 where I send the proposed solution for the implementation of null safety in PaddedBlockCipherImpl. I hope you can review, integrate, or improve it soon.

I look forward to your response. Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants