From c16f7bea10257120f8e105369f329f1e7901439f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9verin=20Beauvais?= Date: Wed, 16 Oct 2024 15:40:15 -0700 Subject: [PATCH] - app version = 5.12.8 (#750) - fixed share structure button styles (outlined) - added punctuation to some hint text - bolded and fixed layout of share structure instruction text (x3) - changed incorporation -> continuation in document delivery section - updated unit tests Co-authored-by: Severin Beauvais --- package-lock.json | 4 ++-- package.json | 2 +- src/components/ContinuationIn/ExtraproRegistration.vue | 4 ++-- src/components/ContinuationIn/ManualBusinessInfo.vue | 4 ++-- src/components/common/ShareStructure.vue | 3 +++ src/views/Amalgamation/ShareStructure.vue | 6 ++++-- src/views/ContinuationIn/ContinuationInReviewConfirm.vue | 2 +- src/views/ContinuationIn/ContinuationInShareStructure.vue | 8 +++++--- src/views/Incorporation/IncorporationShareStructure.vue | 6 ++++-- tests/unit/ContinuationInReviewConfirm.spec.ts | 2 +- tests/unit/ContinuationInShareStructure.spec.ts | 2 +- 11 files changed, 26 insertions(+), 17 deletions(-) diff --git a/package-lock.json b/package-lock.json index 642430a9b..5e16d830f 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "business-create-ui", - "version": "5.12.7", + "version": "5.12.8", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "business-create-ui", - "version": "5.12.7", + "version": "5.12.8", "dependencies": { "@babel/compat-data": "^7.21.5", "@bcrs-shared-components/approval-type": "1.1.3", diff --git a/package.json b/package.json index aef7ba62f..0bceabcd0 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "business-create-ui", - "version": "5.12.7", + "version": "5.12.8", "private": true, "appName": "Create UI", "sbcName": "SBC Common Components", diff --git a/src/components/ContinuationIn/ExtraproRegistration.vue b/src/components/ContinuationIn/ExtraproRegistration.vue index 53ed293be..435a3caaa 100644 --- a/src/components/ContinuationIn/ExtraproRegistration.vue +++ b/src/components/ContinuationIn/ExtraproRegistration.vue @@ -152,7 +152,7 @@ filled persistent-hint label="Business Number (Optional)" - hint="First 9 digits of the CRA Business Number if you have one" + hint="First 9 digits of the CRA Business Number, if you have one." :rules="getShowErrors ? Rules.BusinessNumberRules : []" /> @@ -164,7 +164,7 @@ title="Date of Incorporation" :nudgeRight="40" :nudgeTop="85" - hint="Date of Incorporation, Continuation or Amalgamation in previous jurisdiction" + hint="Date of Incorporation, Continuation or Amalgamation in previous jurisdiction." :persistentHint="true" :initialValue="business.prevIncorporationDate" :inputRules="getShowErrors ? incorporationDateRules: []" diff --git a/src/components/ContinuationIn/ManualBusinessInfo.vue b/src/components/ContinuationIn/ManualBusinessInfo.vue index b6a5c0fb0..3d597f2c6 100644 --- a/src/components/ContinuationIn/ManualBusinessInfo.vue +++ b/src/components/ContinuationIn/ManualBusinessInfo.vue @@ -118,7 +118,7 @@ filled persistent-hint label="Business Number (Optional)" - hint="First 9 digits of the CRA Business Number if you have one" + hint="First 9 digits of the CRA Business Number, if you have one." :rules="getShowErrors ? Rules.BusinessNumberRules : []" /> @@ -130,7 +130,7 @@ title="Date of Incorporation" :nudgeRight="40" :nudgeTop="85" - hint="Date of Incorporation, Continuation or Amalgamation in previous jurisdiction" + hint="Date of Incorporation, Continuation or Amalgamation in previous jurisdiction." :persistentHint="true" :initialValue="getExistingBusinessInfo.prevIncorporationDate" :inputRules="getShowErrors ? incorporationDateRules : []" diff --git a/src/components/common/ShareStructure.vue b/src/components/common/ShareStructure.vue index e20cdc218..b1403287d 100644 --- a/src/components/common/ShareStructure.vue +++ b/src/components/common/ShareStructure.vue @@ -159,6 +159,7 @@ Cancel diff --git a/src/views/Amalgamation/ShareStructure.vue b/src/views/Amalgamation/ShareStructure.vue index c149454e5..ba0567a40 100644 --- a/src/views/Amalgamation/ShareStructure.vue +++ b/src/views/Amalgamation/ShareStructure.vue @@ -79,8 +79,10 @@ -

Your application must include the following:

-
    +
    + Your application must include the following: +
    +

    • Document Delivery

      - Copies of the incorporation documents will be sent to the email addresses listed below. + Copies of the continuation documents will be sent to the email addresses listed below.

      diff --git a/src/views/ContinuationIn/ContinuationInShareStructure.vue b/src/views/ContinuationIn/ContinuationInShareStructure.vue index 7a28007ca..da0bf2252 100644 --- a/src/views/ContinuationIn/ContinuationInShareStructure.vue +++ b/src/views/ContinuationIn/ContinuationInShareStructure.vue @@ -79,9 +79,11 @@ -
      -

      Your application must include the following:

      -
        +
        +
        + Your application must include the following: +
        +
        • -

          Your application must include the following:

          -
            +
            + Your application must include the following: +
            +
            • { // spot check some content (structure / text) const thirdSection = wrapper.findAll('#continuation-in-review-confirm > section').at(2) expect(thirdSection.find('header h2').text()).toBe('Document Delivery') - expect(thirdSection.find('header p').text()).toContain('Copies of the incorporation documents will') + expect(thirdSection.find('header p').text()).toContain('Copies of the continuation documents will') expect(thirdSection.findComponent(DocumentDelivery).exists()).toBe(true) wrapper.destroy() diff --git a/tests/unit/ContinuationInShareStructure.spec.ts b/tests/unit/ContinuationInShareStructure.spec.ts index fbac33a37..ee11ca943 100644 --- a/tests/unit/ContinuationInShareStructure.spec.ts +++ b/tests/unit/ContinuationInShareStructure.spec.ts @@ -27,7 +27,7 @@ describe('Continuation In Share Structure component', () => { // NB: third section is in the help block const fourthSection = wrapper.findAll('section').at(3) - expect(fourthSection.find('p').text()).toBe('Your application must include the following:') + expect(fourthSection.find('div').text()).toBe('Your application must include the following:') expect(wrapper.find('#btn-start-add-cp').exists()).toBe(true) wrapper.destroy()