From ea48ba61a262f7a8294f552fa8377fd999d237a5 Mon Sep 17 00:00:00 2001
From: CameronFreshworks <53542131+cameron-freshworks@users.noreply.github.com>
Date: Tue, 6 Jul 2021 09:54:36 -0700
Subject: [PATCH] Incorporation Application UX Updates (#214)

* ux Updates

* removed test code

* removed statment conditions

* Added safet check

* test updates
---
 package-lock.json                                   | 2 +-
 package.json                                        | 2 +-
 src/components/AddPeopleAndRoles/PeopleAndRoles.vue | 2 +-
 src/resources/benefitCompany.ts                     | 2 +-
 src/resources/communityContributionCompany.ts       | 2 +-
 src/resources/cooperative.ts                        | 4 ++--
 src/resources/limitedCompany.ts                     | 2 +-
 src/resources/unlimitedCompany.ts                   | 2 +-
 src/views/DefineCompany.vue                         | 4 ++--
 tests/unit/DefineCompany.spec.ts                    | 2 +-
 10 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index 17b22be49..442fb730c 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,6 +1,6 @@
 {
   "name": "business-create-ui",
-  "version": "2.0.2",
+  "version": "2.0.3",
   "lockfileVersion": 1,
   "requires": true,
   "dependencies": {
diff --git a/package.json b/package.json
index 744fad971..7f84baa01 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "business-create-ui",
-  "version": "2.0.2",
+  "version": "2.0.3",
   "private": true,
   "appName": "Create UI",
   "sbcName": "SBC Common Components",
diff --git a/src/components/AddPeopleAndRoles/PeopleAndRoles.vue b/src/components/AddPeopleAndRoles/PeopleAndRoles.vue
index 9d18a0f6a..5fbfd2d14 100644
--- a/src/components/AddPeopleAndRoles/PeopleAndRoles.vue
+++ b/src/components/AddPeopleAndRoles/PeopleAndRoles.vue
@@ -59,8 +59,8 @@
         @click="addOrgPerson([{ roleType: RoleTypes.INCORPORATOR }], IncorporatorTypes.CORPORATION)"
       >
         <v-icon>mdi-domain-plus</v-icon>
-        <span v-if="entityFilter(CorpTypeCd.BENEFIT_COMPANY)">Add a Corporation or Firm</span>
         <span v-if="entityFilter(CorpTypeCd.COOP)">Add Organization</span>
+        <span v-else>Add a Corporation or Firm</span>
       </v-btn>
       <v-btn
         v-if="!hasRole(RoleTypes.COMPLETING_PARTY, 1, 'ATLEAST')"
diff --git a/src/resources/benefitCompany.ts b/src/resources/benefitCompany.ts
index d2caff1fd..4c82d7e4d 100644
--- a/src/resources/benefitCompany.ts
+++ b/src/resources/benefitCompany.ts
@@ -6,7 +6,7 @@ import { GetCorpFullDescription } from '@bcrs-shared-components/corp-type-module
 export const BenefitCompanyResource: ResourceIF = {
   entityType: CorpTypeCd.BENEFIT_COMPANY,
   displayName: GetCorpFullDescription(CorpTypeCd.BENEFIT_COMPANY),
-  title: 'Benefit Company Statement',
+  title: 'Benefit Company Statement:',
   description: `This company is a benefit company and, as such, has purposes that include conducting its business
         in a responsible and sustainable manner and promoting one or more public benefits.`,
   statement: null,
diff --git a/src/resources/communityContributionCompany.ts b/src/resources/communityContributionCompany.ts
index 09f1be7de..643b7a9b6 100644
--- a/src/resources/communityContributionCompany.ts
+++ b/src/resources/communityContributionCompany.ts
@@ -6,7 +6,7 @@ import { GetCorpFullDescription } from '@bcrs-shared-components/corp-type-module
 export const CommunityContributionCompanyResource: ResourceIF = {
   entityType: CorpTypeCd.BC_CCC,
   displayName: GetCorpFullDescription(CorpTypeCd.BC_CCC),
-  title: 'Community Contribution Company Statement',
+  title: 'Community Contribution Company Statement:',
   description: `This company is a community contribution company, and, as such, has purposes beneficial to society.
     This company is restricted, in accordance with Part 2.2 of the BCA, in its ability to pay dividends and to
     distribute its assets on dissolution or otherwise.`,
diff --git a/src/resources/cooperative.ts b/src/resources/cooperative.ts
index 72556bc7b..0c7604c76 100644
--- a/src/resources/cooperative.ts
+++ b/src/resources/cooperative.ts
@@ -5,8 +5,8 @@ import { GetCorpFullDescription } from '@bcrs-shared-components/corp-type-module
 export const CooperativeResource: ResourceIF = {
   entityType: CorpTypeCd.COOP,
   displayName: GetCorpFullDescription(CorpTypeCd.COOP),
-  title: null,
-  description: null,
+  title: 'title placeholder',
+  description: 'descriptor placeholder',
   statement: null,
   nameRequestType: null, // TBD
   steps: [],
diff --git a/src/resources/limitedCompany.ts b/src/resources/limitedCompany.ts
index a7188ba13..0b8d1a8da 100644
--- a/src/resources/limitedCompany.ts
+++ b/src/resources/limitedCompany.ts
@@ -6,7 +6,7 @@ import { GetCorpFullDescription } from '@bcrs-shared-components/corp-type-module
 export const LimitedCompanyResource: ResourceIF = {
   entityType: CorpTypeCd.BC_COMPANY,
   displayName: GetCorpFullDescription(CorpTypeCd.BC_COMPANY),
-  title: 'Limited Company Statement',
+  title: null,
   description: null,
   statement: null,
   nameRequestType: NameRequestTypes.CR,
diff --git a/src/resources/unlimitedCompany.ts b/src/resources/unlimitedCompany.ts
index 00cd677ac..5eb264e0b 100644
--- a/src/resources/unlimitedCompany.ts
+++ b/src/resources/unlimitedCompany.ts
@@ -6,7 +6,7 @@ import { GetCorpFullDescription } from '@bcrs-shared-components/corp-type-module
 export const UnlimitedCompanyResource: ResourceIF = {
   entityType: CorpTypeCd.BC_ULC_COMPANY,
   displayName: GetCorpFullDescription(CorpTypeCd.BC_ULC_COMPANY),
-  title: 'Unlimited Company Statement',
+  title: 'Unlimited Liability Company Statement:',
   description: `The shareholders of this company are jointly and severally liable to satisfy the debts and liabilities
     of this company to the extent provided in section 51.3 of the Business Corporations Act.`,
   statement: null,
diff --git a/src/views/DefineCompany.vue b/src/views/DefineCompany.vue
index 5d4c9ed00..ec25bfce0 100644
--- a/src/views/DefineCompany.vue
+++ b/src/views/DefineCompany.vue
@@ -1,8 +1,8 @@
 <template>
   <div>
     <div class="mt-10 company-statement">
-      <p>
-        <span class="company-statement-label">{{ getCompanyResources.title }}:</span>
+      <p v-if="getCompanyResources.title">
+        <span class="company-statement-label">{{ getCompanyResources.title }}</span>
         {{ getCompanyResources.description }}
       </p>
     </div>
diff --git a/tests/unit/DefineCompany.spec.ts b/tests/unit/DefineCompany.spec.ts
index 0abbfaf42..884373136 100644
--- a/tests/unit/DefineCompany.spec.ts
+++ b/tests/unit/DefineCompany.spec.ts
@@ -63,7 +63,7 @@ for (const mock of mockEntityInfo) {
       expect(wrapper.find('#folio-number-header').text()).toContain('Folio / Reference Number (optional)')
     })
 
-    it(`displays company statement`, () => {
+    itIf(mock.entityType !== 'BC')(`displays company statement`, () => {
       expect(wrapper.find('.company-statement').exists()).toBe(true)
       expect(wrapper.find('.company-statement p').text()).toContain(mock.description)