From 214c5a8161db32ad9aab41fe13a273559ddab135 Mon Sep 17 00:00:00 2001 From: meganwong Date: Mon, 4 Nov 2024 11:52:17 -0800 Subject: [PATCH 1/2] Reset certify validity on mount --- .../Incorporation/IncorporationReviewConfirm.vue | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/views/Incorporation/IncorporationReviewConfirm.vue b/src/views/Incorporation/IncorporationReviewConfirm.vue index cfefa41f..fcf89a62 100644 --- a/src/views/Incorporation/IncorporationReviewConfirm.vue +++ b/src/views/Incorporation/IncorporationReviewConfirm.vue @@ -303,6 +303,17 @@ export default class IncorporationReviewConfirm extends Vue { @Action(useStore) setHasPlanOfArrangement!: (x: boolean) => void @Action(useStore) setIsFutureEffective!: (x: boolean) => void + /** + * In case submitting the incorporation failed, we want to reset the validity of Certify. + * This is since the checkbox has to be ticked again after the save dialog has been closed. + */ + mounted (): void { + this.setCertifyState({ + certifiedBy: this.getCertifyState.certifiedBy, + valid: false + }) + } + /** The entity description, */ get getEntityDescription (): string { return GetCorpFullDescription(this.getEntityType) From 2e4669f3d866cd3f7295919d4d7f399816942fe5 Mon Sep 17 00:00:00 2001 From: meganwong Date: Mon, 4 Nov 2024 12:00:35 -0800 Subject: [PATCH 2/2] fix lint error and update patch version --- package-lock.json | 4 ++-- package.json | 2 +- src/views/Incorporation/IncorporationReviewConfirm.vue | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/package-lock.json b/package-lock.json index c025d3b9..c9e2de84 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "business-create-ui", - "version": "5.14.0", + "version": "5.14.1", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "business-create-ui", - "version": "5.14.0", + "version": "5.14.1", "dependencies": { "@babel/compat-data": "^7.21.5", "@bcrs-shared-components/approval-type": "1.1.3", diff --git a/package.json b/package.json index 7dbaa870..03b6e639 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "business-create-ui", - "version": "5.14.0", + "version": "5.14.1", "private": true, "appName": "Create UI", "sbcName": "SBC Common Components", diff --git a/src/views/Incorporation/IncorporationReviewConfirm.vue b/src/views/Incorporation/IncorporationReviewConfirm.vue index fcf89a62..426a50a6 100644 --- a/src/views/Incorporation/IncorporationReviewConfirm.vue +++ b/src/views/Incorporation/IncorporationReviewConfirm.vue @@ -307,7 +307,7 @@ export default class IncorporationReviewConfirm extends Vue { * In case submitting the incorporation failed, we want to reset the validity of Certify. * This is since the checkbox has to be ticked again after the save dialog has been closed. */ - mounted (): void { + mounted (): void { this.setCertifyState({ certifiedBy: this.getCertifyState.certifiedBy, valid: false