From 3134b5e0410c73f18edb4dfd6d786cb3a8b7b380 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9verin=20Beauvais?= Date: Mon, 24 Apr 2023 11:44:35 -0700 Subject: [PATCH] - added eslint presets (#489) - enabled eslint rule overrides - app version = 4.3.3 - auto-fixed "id must come first" - auto-fixed "one property per line" - auto-fixed "property needs double quotes" - auto-fixed "v-for must come first" - auto-fixed "one space after {{ and before }}" - auto-fixed "use self-closing HTML elements" - auto-fixed "#activator" - auto-fixed "key must come before other properties" - etc --- .eslintrc.js | 14 +- package-lock.json | 4 +- package.json | 2 +- src/App.vue | 35 +- .../Alteration/AlterationSummary.vue | 80 +++-- .../Alteration/Articles/Articles.vue | 9 +- .../Alteration/Articles/CompanyProvisions.vue | 74 ++++- .../Alteration/Articles/ResolutionDates.vue | 111 +++++-- src/components/Change/ChangeSummary.vue | 65 +++- src/components/Conversion/ConversionNOB.vue | 108 ++++-- .../Conversion/ConversionSummary.vue | 41 ++- .../Restoration/ExtendTimeLimit.vue | 25 +- .../Restoration/RestorationSummary.vue | 18 +- .../Restoration/YourCompanySummary.vue | 54 ++- .../CreateSpecialResolution.vue | 151 ++++++--- .../CreateSpecialResolutionSummary.vue | 98 ++++-- .../SpecialResolutionSummary.vue | 22 +- src/components/ViewWrapper.vue | 17 +- src/components/common/Actions.vue | 24 +- src/components/common/BcRegContacts.vue | 26 +- src/components/common/CertifySection.vue | 12 +- src/components/common/CompletingParty.vue | 7 +- src/components/common/CourtOrderPoa.vue | 12 +- src/components/common/Detail.vue | 19 +- src/components/common/DocumentsDelivery.vue | 53 ++- src/components/common/EffectiveDateTime.vue | 86 +++-- src/components/common/EntityInfo.vue | 28 +- src/components/common/ErrorContact.vue | 36 +- src/components/common/HelpSection.vue | 38 ++- .../PeopleAndRoles/CurrentDirectors.vue | 36 +- .../PeopleAndRoles/ListPeopleAndRoles.vue | 276 +++++++++++---- .../common/PeopleAndRoles/OrgPerson.vue | 186 +++++++---- .../common/PeopleAndRoles/PeopleAndRoles.vue | 180 +++++++--- src/components/common/QuestionWrapper.vue | 21 +- src/components/common/StaffPayment.vue | 17 +- .../common/TransactionalFolioNumber.vue | 27 +- .../common/YourCompany/AssociationType.vue | 146 +++++--- .../common/YourCompany/BusinessStartDate.vue | 106 ++++-- .../common/YourCompany/ChangeBusinessType.vue | 199 +++++++---- .../CompanyName/CorrectCompanyName.vue | 9 +- .../CompanyName/CorrectNameOptions.vue | 41 ++- .../CompanyName/CorrectNameRequest.vue | 56 +++- .../CompanyName/CorrectNameToNumber.vue | 7 +- .../common/YourCompany/EntityName.vue | 114 +++++-- .../NameTranslations/AddNameTranslation.vue | 26 +- .../NameTranslations/ListNameTranslation.vue | 78 +++-- .../NameTranslations/NameTranslation.vue | 91 +++-- .../common/YourCompany/OfficeAddresses.vue | 314 +++++++++++++----- .../YourCompany/RecognitionDateTime.vue | 7 +- .../common/YourCompany/YourCompanyWrapper.vue | 11 +- src/dialogs/AccountAuthorizationDialog.vue | 40 ++- src/dialogs/ConfirmDeleteAllDialog.vue | 30 +- src/dialogs/ConfirmRemoveDialog.vue | 33 +- src/dialogs/FetchErrorDialog.vue | 44 ++- .../FileAndPayInvalidNameRequestDialog.vue | 37 ++- src/dialogs/NameRequestErrorDialog.vue | 52 ++- src/dialogs/PaymentErrorDialog.vue | 72 +++- src/dialogs/ResolutionDateDialog.vue | 39 ++- src/dialogs/SaveErrorDialog.vue | 98 ++++-- src/dialogs/StaffPaymentErrorDialog.vue | 55 ++- src/views/Alteration.vue | 11 +- src/views/Change.vue | 5 +- src/views/Conversion.vue | 5 +- src/views/Correction.vue | 1 - src/views/Correction/CorpCorrection.vue | 16 +- src/views/Correction/FirmCorrection.vue | 6 +- src/views/LimitedRestorationExtension.vue | 25 +- src/views/LimitedRestorationToFull.vue | 25 +- src/views/SpecialResolution.vue | 13 +- tests/unit/AlterationSummary.spec.ts | 3 +- 70 files changed, 2871 insertions(+), 956 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 2777014c9..be6f2febc 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -8,11 +8,11 @@ module.exports = { 'plugin:@typescript-eslint/recommended', 'plugin:vue/base', 'plugin:vue/essential', - // 'plugin:vue/recommended', - // 'plugin:vue/strongly-recommended', + 'plugin:vue/recommended', + 'plugin:vue/strongly-recommended', 'plugin:vue/vue3-essential', - // 'plugin:vue/vue3-recommended', - // 'plugin:vue/vue3-strongly-recommended', + 'plugin:vue/vue3-recommended', + 'plugin:vue/vue3-strongly-recommended', 'plugin:vuetify/base', 'plugin:vuetify/recommended', '@vue/standard', @@ -22,10 +22,10 @@ module.exports = { 'no-console': process.env.NODE_ENV === 'production' ? 'warn' : 'off', 'no-debugger': process.env.NODE_ENV === 'production' ? 'error' : 'off', 'max-len': ['warn', { code: 120, ignoreRegExpLiterals: true }], - // 'vue/attribute-hyphenation': 'off', - // 'vue/no-deprecated-filter': 'warn', + 'vue/attribute-hyphenation': 'off', + 'vue/no-deprecated-filter': 'warn', 'vue/no-deprecated-slot-scope-attribute': 'warn', - // 'vue/no-deprecated-v-on-native-modifier': 'warn', + 'vue/no-deprecated-v-on-native-modifier': 'warn', 'vue/no-v-for-template-key-on-child': 'warn', 'vue/no-v-html': 'off', 'vue/v-on-event-hyphenation': 'off', diff --git a/package-lock.json b/package-lock.json index a3225ecb8..ea3f8fba6 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "business-edit-ui", - "version": "4.3.2", + "version": "4.3.3", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "business-edit-ui", - "version": "4.3.2", + "version": "4.3.3", "dependencies": { "@babel/compat-data": "^7.19.1", "@bcrs-shared-components/action-chip": "1.1.5", diff --git a/package.json b/package.json index 1b8b74229..09e63d92e 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "business-edit-ui", - "version": "4.3.2", + "version": "4.3.3", "private": true, "appName": "Edit UI", "sbcName": "SBC Common Components", diff --git a/src/App.vue b/src/App.vue index 09b5c86b6..4873c477c 100644 --- a/src/App.vue +++ b/src/App.vue @@ -1,5 +1,8 @@ diff --git a/src/components/Alteration/AlterationSummary.vue b/src/components/Alteration/AlterationSummary.vue index 0edcb6286..35cfaf503 100644 --- a/src/components/Alteration/AlterationSummary.vue +++ b/src/components/Alteration/AlterationSummary.vue @@ -1,23 +1,35 @@ @@ -125,16 +154,26 @@ + :class="{ 'invalid': alterationDateTimeInvalid }" + > - + - -

+ +

Select the date and time of alteration of your business. You may select a date and time up to 10 days in - the future (note: there is an additional fee {{futureEffectiveFeePrice}} to + the future (note: there is an additional fee {{ futureEffectiveFeePrice }} to enter an alteration date and time in the future). Unless a business has special requirements, most businesses select an immediate Alteration Date and Time.

@@ -146,12 +185,13 @@ /> + > The alteration for this business will be effective as of:
- {{effectiveDateTimeString}} + {{ effectiveDateTimeString }}
diff --git a/src/components/Alteration/Articles/Articles.vue b/src/components/Alteration/Articles/Articles.vue index 06acd3c84..ce480b360 100644 --- a/src/components/Alteration/Articles/Articles.vue +++ b/src/components/Alteration/Articles/Articles.vue @@ -1,7 +1,12 @@