From 7e18d4aa09ef80effd49d090c506c288ebcd1e41 Mon Sep 17 00:00:00 2001 From: Travis Semple Date: Fri, 23 Jun 2023 12:11:28 -0700 Subject: [PATCH] 15951 - Special Resolution Corrections (#508) * Touch ups from UX. * Special Resolution Corrections * Update package + package.lock. * Fixes based on feedback. * Typo * Update remove debugger, update interfaces. * Add in null * Small fixes for base filing. * Feedback changes. * One more spot. * Remove comment * Remove comment * Unit test fix. * Use beforeEach instead of beforeAll. --- jest.config.js | 3 +- package-lock.json | 32 +- package.json | 4 +- .../CreateSpecialResolution.vue | 109 ------- ...ecialResolution.vue => HelpResolution.vue} | 14 +- .../SpecialResolution/InstructionalText.vue | 11 +- .../SpecialResolution/Memorandum.vue | 12 +- .../SpecialResolution/Resolution.vue | 252 +++++++++++++++ .../SpecialResolution/ResolutionEditor.vue | 169 ++++++---- ...utionSummary.vue => ResolutionSummary.vue} | 6 +- src/components/SpecialResolution/Rules.vue | 13 +- .../SpecialResolution/SigningParty.vue | 101 ++++-- .../SpecialResolutionSummary.vue | 6 +- src/components/SpecialResolution/index.ts | 6 +- src/components/common/Detail.vue | 6 +- .../common/YourCompany/AssociationType.vue | 20 +- .../alteration-interface.ts | 22 +- .../business-snapshot-interface.ts | 4 +- .../resolutions-interface.ts | 8 +- .../correction-information-interface.ts | 14 +- .../store-interfaces/state-model-interface.ts | 2 + src/mixins/filing-template-mixin.ts | 219 ++++++++----- src/resources/Correction/CP.ts | 49 +++ src/resources/Correction/index.ts | 1 + src/resources/SpecialResolution/CP.ts | 2 +- src/services/legal-services.ts | 13 +- src/store/state/state-model.ts | 4 +- src/store/store.ts | 88 +++++- src/views/Correction.vue | 8 +- src/views/Correction/CoopCorrection.vue | 210 +++++++++++++ src/views/SpecialResolution.vue | 6 +- tests/unit/AccountAuthorizationDialog.spec.ts | 2 - tests/unit/Actions.spec.ts | 1 - tests/unit/AddNameTranslation.spec.ts | 1 - tests/unit/Alteration.spec.ts | 1 - tests/unit/AlterationSummary.spec.ts | 1 - tests/unit/App.spec.ts | 1 - tests/unit/Articles.spec.ts | 1 - tests/unit/AssociationType.spec.ts | 2 - tests/unit/BusinessContactInfo.spec.ts | 1 - tests/unit/BusinessStartDate.spec.ts | 1 - tests/unit/CertifySection.spec.ts | 2 - tests/unit/Change.spec.ts | 1 - tests/unit/ChangeBusinessType.spec.ts | 2 - tests/unit/ChangeSummary.spec.ts | 1 - tests/unit/CommonCompletingParty.spec.ts | 2 - tests/unit/CompanyProvisions.spec.ts | 1 - tests/unit/Conversion.spec.ts | 1 - tests/unit/ConversionNOB.spec.ts | 1 - tests/unit/ConversionSummary.spec.ts | 1 - tests/unit/CoopCorrection.spec.ts | 289 ++++++++++++++++++ tests/unit/CorpCorrection.spec.ts | 1 - tests/unit/CorrectBusinessType.spec.ts | 1 - tests/unit/CorrectCompanyName.spec.ts | 2 - tests/unit/CorrectName.spec.ts | 1 - tests/unit/CorrectNameRequest.spec.ts | 2 - tests/unit/CorrectNameToNumber.spec.ts | 1 - tests/unit/CourtOrderPoa.spec.ts | 2 - tests/unit/Detail.spec.ts | 2 - tests/unit/DocumentDelivery.spec.ts | 2 - tests/unit/EffectiveDateTime.spec.ts | 2 - tests/unit/EntityInfo.spec.ts | 2 - tests/unit/EntityName.spec.ts | 1 - tests/unit/ErrorContact.spec.ts | 2 - tests/unit/ExtendTimeLimit.spec.ts | 2 - tests/unit/FetchErrorDialog.spec.ts | 2 - ...FileAndPayInvalidNameRequestDialog.spec.ts | 2 - tests/unit/FirmCorrection.spec.ts | 1 - tests/unit/FolioInformation.spec.ts | 2 - tests/unit/InstructionalText.spec.ts | 13 +- .../unit/LimitedRestorationExtension.spec.ts | 1 - tests/unit/LimitedRestorationToFull.spec.ts | 1 - tests/unit/ListNameTranslations.spec.ts | 1 - tests/unit/ListPeopleAndRoles.spec.ts | 6 - tests/unit/Memorandum.spec.ts | 1 - tests/unit/NameRequestErrorDialog.spec.ts | 1 - tests/unit/NameTranslation.spec.ts | 1 - tests/unit/OfficeAddresses.spec.ts | 5 - tests/unit/OrgPerson.spec.ts | 5 - tests/unit/PaymentErrorDialog.spec.ts | 2 - tests/unit/PeopleAndRoles.spec.ts | 6 - ...lResolution.spec.ts => Resolution.spec.ts} | 89 ++++-- tests/unit/ResolutionDates.spec.ts | 1 - tests/unit/ResolutionEditor.spec.ts | 41 ++- ...mary.spec.ts => ResolutionSummary.spec.ts} | 10 +- tests/unit/RestorationSummary.spec.ts | 1 - tests/unit/Rules.spec.ts | 1 - tests/unit/SaveErrorDialog.spec.ts | 2 - tests/unit/ShareStructures.spec.ts | 1 - tests/unit/SigningParty.spec.ts | 39 ++- tests/unit/SpecialResolution.spec.ts | 1 - tests/unit/SpecialResolutionSummary.spec.ts | 3 - tests/unit/StaffPaymentErrorDialog.spec.ts | 2 - tests/unit/TransactionalFolioNumber.spec.ts | 2 - tests/unit/ViewWrapper.spec.ts | 2 - tests/unit/legal-services.spec.ts | 61 ++++ tests/unit/setup.ts | 30 ++ tests/unit/state-getters.spec.ts | 1 - 98 files changed, 1601 insertions(+), 486 deletions(-) delete mode 100644 src/components/SpecialResolution/CreateSpecialResolution.vue rename src/components/SpecialResolution/{HelpSpecialResolution.vue => HelpResolution.vue} (93%) create mode 100644 src/components/SpecialResolution/Resolution.vue rename src/components/SpecialResolution/{CreateSpecialResolutionSummary.vue => ResolutionSummary.vue} (97%) create mode 100644 src/resources/Correction/CP.ts create mode 100644 src/views/Correction/CoopCorrection.vue create mode 100644 tests/unit/CoopCorrection.spec.ts rename tests/unit/{CreateSpecialResolution.spec.ts => Resolution.spec.ts} (60%) rename tests/unit/{CreateSpecialResolutionSummary.spec.ts => ResolutionSummary.spec.ts} (88%) create mode 100644 tests/unit/setup.ts diff --git a/jest.config.js b/jest.config.js index 36d60281f..04bbcecc1 100644 --- a/jest.config.js +++ b/jest.config.js @@ -7,5 +7,6 @@ module.exports = { } }, preset: '@vue/cli-plugin-unit-jest/presets/typescript-and-babel', - transformIgnorePatterns: [] + transformIgnorePatterns: [], + setupFiles: ['./tests/unit/setup.ts'] } diff --git a/package-lock.json b/package-lock.json index 96b71d7e7..6dcb01832 100644 --- a/package-lock.json +++ b/package-lock.json @@ -21,11 +21,11 @@ "@bcrs-shared-components/court-order-poa": "2.1.3", "@bcrs-shared-components/date-picker": "1.2.5", "@bcrs-shared-components/detail-comment": "1.1.1", - "@bcrs-shared-components/enums": "1.0.38", + "@bcrs-shared-components/enums": "1.0.39", "@bcrs-shared-components/fee-summary": "1.2.5", "@bcrs-shared-components/folio-number": "1.1.1", "@bcrs-shared-components/help-business-number": "1.1.1", - "@bcrs-shared-components/interfaces": "1.0.60", + "@bcrs-shared-components/interfaces": "1.0.63", "@bcrs-shared-components/limited-restoration-panel": "2.0.1", "@bcrs-shared-components/nature-of-business": "1.2.4", "@bcrs-shared-components/relationships-panel": "1.0.14", @@ -1967,9 +1967,9 @@ } }, "node_modules/@bcrs-shared-components/enums": { - "version": "1.0.38", - "resolved": "https://registry.npmjs.org/@bcrs-shared-components/enums/-/enums-1.0.38.tgz", - "integrity": "sha512-zv8pevmYgqB/dCgezMJuoxGsse6Crmgxkg0YdnPBCD1g93vq6X7rBDweZ4MLcSCFfq3yPTH0JPhixu89C+YBOw==", + "version": "1.0.39", + "resolved": "https://registry.npmjs.org/@bcrs-shared-components/enums/-/enums-1.0.39.tgz", + "integrity": "sha512-+K2ijM+SlGpeALrqPPJ8xWj4hJnh2WI+gAhWjt8CDf11wHl0pVaXBDB6o9BeYbwahEBKpU2SvOrNYIQ2K20kng==", "dependencies": { "@bcrs-shared-components/corp-type-module": "^1.0.12" } @@ -2058,11 +2058,11 @@ } }, "node_modules/@bcrs-shared-components/interfaces": { - "version": "1.0.60", - "resolved": "https://registry.npmjs.org/@bcrs-shared-components/interfaces/-/interfaces-1.0.60.tgz", - "integrity": "sha512-53XQ2g34q+MVMO64vtlwq/2z5W4x1VWnloU52vJK6vuvy6OTjRcEaAHDP0/VV518uHeOsaPMGUZbxl3yfBxzAw==", + "version": "1.0.63", + "resolved": "https://registry.npmjs.org/@bcrs-shared-components/interfaces/-/interfaces-1.0.63.tgz", + "integrity": "sha512-HXmf4wVbzAhVoznxpkp+V+4rMXCbI+btt4RmE523W8DZaZseFfvvsbg7z4qP1eRK7JIiQyQS6TcqnPpC51TxmQ==", "dependencies": { - "@bcrs-shared-components/enums": "^1.0.38", + "@bcrs-shared-components/enums": "^1.0.39", "vue": "^2.7.10" } }, @@ -22039,9 +22039,9 @@ } }, "@bcrs-shared-components/enums": { - "version": "1.0.38", - "resolved": "https://registry.npmjs.org/@bcrs-shared-components/enums/-/enums-1.0.38.tgz", - "integrity": "sha512-zv8pevmYgqB/dCgezMJuoxGsse6Crmgxkg0YdnPBCD1g93vq6X7rBDweZ4MLcSCFfq3yPTH0JPhixu89C+YBOw==", + "version": "1.0.39", + "resolved": "https://registry.npmjs.org/@bcrs-shared-components/enums/-/enums-1.0.39.tgz", + "integrity": "sha512-+K2ijM+SlGpeALrqPPJ8xWj4hJnh2WI+gAhWjt8CDf11wHl0pVaXBDB6o9BeYbwahEBKpU2SvOrNYIQ2K20kng==", "requires": { "@bcrs-shared-components/corp-type-module": "^1.0.12" }, @@ -22134,11 +22134,11 @@ } }, "@bcrs-shared-components/interfaces": { - "version": "1.0.60", - "resolved": "https://registry.npmjs.org/@bcrs-shared-components/interfaces/-/interfaces-1.0.60.tgz", - "integrity": "sha512-53XQ2g34q+MVMO64vtlwq/2z5W4x1VWnloU52vJK6vuvy6OTjRcEaAHDP0/VV518uHeOsaPMGUZbxl3yfBxzAw==", + "version": "1.0.63", + "resolved": "https://registry.npmjs.org/@bcrs-shared-components/interfaces/-/interfaces-1.0.63.tgz", + "integrity": "sha512-HXmf4wVbzAhVoznxpkp+V+4rMXCbI+btt4RmE523W8DZaZseFfvvsbg7z4qP1eRK7JIiQyQS6TcqnPpC51TxmQ==", "requires": { - "@bcrs-shared-components/enums": "^1.0.38", + "@bcrs-shared-components/enums": "^1.0.39", "vue": "^2.7.10" } }, diff --git a/package.json b/package.json index 4c59a9089..38fdd5079 100644 --- a/package.json +++ b/package.json @@ -26,11 +26,11 @@ "@bcrs-shared-components/court-order-poa": "2.1.3", "@bcrs-shared-components/date-picker": "1.2.5", "@bcrs-shared-components/detail-comment": "1.1.1", - "@bcrs-shared-components/enums": "1.0.38", + "@bcrs-shared-components/enums": "1.0.39", "@bcrs-shared-components/fee-summary": "1.2.5", "@bcrs-shared-components/folio-number": "1.1.1", "@bcrs-shared-components/help-business-number": "1.1.1", - "@bcrs-shared-components/interfaces": "1.0.60", + "@bcrs-shared-components/interfaces": "1.0.63", "@bcrs-shared-components/limited-restoration-panel": "2.0.1", "@bcrs-shared-components/nature-of-business": "1.2.4", "@bcrs-shared-components/relationships-panel": "1.0.14", diff --git a/src/components/SpecialResolution/CreateSpecialResolution.vue b/src/components/SpecialResolution/CreateSpecialResolution.vue deleted file mode 100644 index af9ddc02a..000000000 --- a/src/components/SpecialResolution/CreateSpecialResolution.vue +++ /dev/null @@ -1,109 +0,0 @@ - - - - - diff --git a/src/components/SpecialResolution/HelpSpecialResolution.vue b/src/components/SpecialResolution/HelpResolution.vue similarity index 93% rename from src/components/SpecialResolution/HelpSpecialResolution.vue rename to src/components/SpecialResolution/HelpResolution.vue index 2b580c189..6722e54da 100644 --- a/src/components/SpecialResolution/HelpSpecialResolution.vue +++ b/src/components/SpecialResolution/HelpResolution.vue @@ -1,5 +1,9 @@