Skip to content

Commit

Permalink
16851 - Styling issues in the correction module (#537)
Browse files Browse the repository at this point in the history
* ui fixes from yui

* version

* override comment
  • Loading branch information
bennypc authored Aug 1, 2023
1 parent cf37c68 commit bef1b9b
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 5 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-filings-ui",
"version": "6.6.6",
"version": "6.6.7",
"private": true,
"appName": "Filings UI",
"sbcName": "SBC Common Components",
Expand Down
1 change: 1 addition & 0 deletions src/components/common/Certify.vue
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ export default class Certify extends Vue {
@Emit('update:isCertified')
emitIsCertified (isCertified: boolean): boolean {
this.emitValid(!!this.trimmedCertifiedBy && isCertified)
this.checkboxState = isCertified
return isCertified
}
Expand Down
3 changes: 2 additions & 1 deletion src/components/common/DetailComment.vue
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
<v-textarea
id="detail-comment-textarea"
ref="textarea"
class="pt-2"
filled
auto-grow
rows="5"
persistent-hint
Expand Down Expand Up @@ -119,7 +121,6 @@ export default class DetailComment extends Vue {
.theme--light.v-label {
padding-left: 12px;
padding-bottom: 12px;
margin-top: -3px;
}
}
}
Expand Down
17 changes: 16 additions & 1 deletion src/views/Correction.vue
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@
:isCertified.sync="isCertified"
:certifiedBy.sync="certifiedBy"
:validateForm="showErrors"
:class="{ 'invalid-certify': !certifyFormValid && showErrors}"
:entityDisplay="displayName()"
:message="certifyText(FilingCodes.ANNUAL_REPORT_OT)"
@valid="certifyFormValid=$event"
Expand Down Expand Up @@ -192,8 +193,8 @@
<div class="buttons-right">
<v-tooltip
top
color="tooltipColor"
content-class="top-tooltip"
transition="fade-transition"
>
<template #activator="{ on }">
<div
Expand Down Expand Up @@ -954,6 +955,10 @@ h2 {
}
}
.v-tooltip__content {
margin-top: -10px;
}
// Save & Filing Buttons
#correction-buttons-container {
padding-top: 2rem;
Expand All @@ -975,4 +980,14 @@ h2 {
margin-left: 0.5rem;
}
}
:deep() {
// To ensure validation for Certify
.invalid-certify {
.certify-stmt, .title-label {
color: $app-red;
}
}
}
</style>

0 comments on commit bef1b9b

Please sign in to comment.