Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTHUB - Data Upload Error and Warning Notification BACKEND #365

Open
emi-hi opened this issue Jul 10, 2024 · 3 comments
Open

CTHUB - Data Upload Error and Warning Notification BACKEND #365

emi-hi opened this issue Jul 10, 2024 · 3 comments
Assignees
Labels
Medium Medium priority Task Any work that does not directly impact the user Tested :) Passed testing

Comments

@emi-hi
Copy link
Collaborator

emi-hi commented Jul 10, 2024

Title:
Data Upload Error and Warning Notification

Description:
When uploading data, a pop-up will display the number of errors and warnings. All errors must be fixed before proceeding with the upload, while warnings are optional and can be reviewed by the user to decide whether to proceed. Both errors and warnings will be listed, showing specific column and row issues. If only warnings are present, the user can view the list and choose whether to continue with the upload.

Wireframe:
[Insert Wireframe Link Here]https://www.figma.com/design/K7gNHRnlYuG27w8XGVquY5/Warnings%2FErrors?node-id=0-1&t=ahNSzQ6AP3ezAoZi-1
[Insert Prototype Link Here]https://www.figma.com/proto/K7gNHRnlYuG27w8XGVquY5/Warnings%2FErrors?node-id=1-66&t=haXC8FQ7dCXd8Kcs-1&scaling=scale-down-width&content-scaling=fixed&page-id=0%3A1&starting-point-node-id=1%3A66

Purpose and benefit to user:
This feature guarantees data integrity by requiring users to address all errors before uploading, reducing potential issues with data accuracy and data analytics. The option to review warnings provides flexibility, allowing users to determine whether the information is needed or not..

Acceptance Criteria:
Given I am a user uploading a spreadsheet with errors/warnings, the backend response contains the total errors/warnings counts and all the errors/warnings broken down by column

{Column: Name,
Error Type: “x not formatted correctly ”,
Expected Format: “213-1234-1231”,
Rows: [1,2,3],
Severity: Error , Warning
}

JulianForeman added a commit that referenced this issue Jul 25, 2024
* feat: (partial) adds components for displaying issues, modifies popup

* -feat: new issues component working as expected with errors and warnings split up

* -adds issue type to detail ie 'warning name' or 'error name'

* First version of backend refactor

* Cleanup

---------

Co-authored-by: emi-hi <[email protected]>
Co-authored-by: Emily <[email protected]>
@Lalita-Lala
Copy link
Collaborator

Lalita-Lala commented Jul 29, 2024

I wanted to share a few observations from the recent test, along with some suggestions for improvement. The work overall is excellent, and these are just a few adjustments to consider:

  1. The exclamation mark icon in the circle (or the icon displayed in the pop-up window and main error and warning blocks) should be properly formatted as an exclamation mark.
  2. The error and warning blocks should use “Errors” and “Warnings” in plural form.
  3. When there are multiple errors in a single column, each Error Name should be preceded by a number (e.g., (1), (2)).
  4. The errors are listed in the correct sequence (Error name, Expected value, Rows with error) but the description isn’t entirely accurate.
    The descriptions themselves need to be revised. I have provided a link and the image to the correct descriptions for each error, including the maximum number of errors allowed per column (e.g., if a table can have no more than 2 errors, then no more than 2 errors should appear).
    https://www.figma.com/design/K7gNHRnlYuG27w8XGVquY5/Warnings%2FErrors?node-id=99-614&t=I8wrzyrxl8l4AKeu-1

I hope these suggestions are helpful. The work so far is impressive, and with these minor tweaks, it will be even better!

Image

@JulianForeman
Copy link
Collaborator

JulianForeman commented Jul 30, 2024

I have implemented the majority of these fixes. 1-3 are done; but I think addressing 4 is going to take more work than it looks like on the surface. I think this is something that should be made it's own ticket because it will likely require sending new specific data structure to the frontend for certain errors.

@shayjeff
Copy link
Collaborator

shayjeff commented Aug 8, 2024

Another card was created to address number 4.

@shayjeff shayjeff added Medium Medium priority Task Any work that does not directly impact the user Tested :) Passed testing labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Medium Medium priority Task Any work that does not directly impact the user Tested :) Passed testing
Projects
None yet
Development

No branches or pull requests

4 participants