AWESOME! #72
Comments
|
Thanks, Laura! I think that is a great idea and would love to collaborate. I'm all for promotion and complementing other hydrology R packages. I'm working on updating fasstr for the next release and could include a vignette on how to integrate dataRetrieval into the proper formatting for fasstr; but am also open to writing a blog about it. Do you have anything specific in mind to promote this? Thanks for reaching out! |
|
A vignette would be perfect. I could ask around for nice dataRetrieval examples to highlight certain functions. If you had a current workflow that you'd like to start with, let me know. Otherwise, at some point in the near future, I'll try duplicating the frequency analysis vignette with a dataRetrieval input. After I do that, I should have a better idea how hard/easy this would be. |
|
Very interested to know whether you've managed to make this happen? I like the looks of fasstr, but does it play nice with dataRetrieval yet? |
|
Hey @ldecicco-USGS and @peteymoore! It's been a hot minute since I've started it, but I've written up a draft vignette for how to integrate dataRetrieval with fasstr. Have a look at it and let me know what you think. Any recommendations or suggestions of other workflows are very much welcome. Feel free to make a pull request of changes if need be. See vignette code here: https://github.com/bcgov/fasstr/blob/master/vignettes/articles/fasstr_dataRetrieval.Rmd |
|
I made some decisions about US unit conversions that seem to be consistent with some US analyses (for example, inches depth of runoff vs metric millimetres), so if those units make sense and/or there should be other unit analyses (i.e. acre-feet or other), feel free to let me know or suggest some options. |
|
It looks great! From my perspective, the units look good the way you set it up. You could put your conversion factors up on top as a variable so if someone wanted to do something else, they wouldn't have to change 0.028317 (or 2.58999) a bunch of times. |
|
Great idea, @ldecicco-USGS. I have included your conversion suggestion and also added some acre-feet examples. |
|
Jon-
Thanks much, I'm excited to give it a test-drive!
-Pete
…On Thu, Nov 25, 2021 at 4:34 PM Jon Goetz ***@***.***> wrote:
Great idea, @ldecicco-USGS <https://github.com/ldecicco-USGS>. I have
included your conversion suggestion and also added some acre-feet examples.
When I push the next fasstr version to CRAN, the GitHub page will include
the vignette also.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#72 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7Y2O5MJWRLPFQMWQ5JOSTUN22XHANCNFSM4RL5OC2A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Vignette now live on Github Page: https://bcgov.github.io/fasstr/articles/fasstr_dataRetrieval.html |
Wanted to say it looks like a great package! It would be awesome to write a blog or something that uses the US dataRetrieval package (this complements the idea to make a blog or vignette that uses tidyhydat data in
EGRET(http://usgs-r.github.io/EGRET/)Related:
DOI-USGS/dataRetrieval#421
The text was updated successfully, but these errors were encountered: