From cef77fd16dd050a12647a5abbd27b1e8ef96f6d9 Mon Sep 17 00:00:00 2001 From: Hamed Valiollahi Bayeki Date: Tue, 17 Dec 2024 14:37:17 -0800 Subject: [PATCH] fix: relocate 'Comments to the Director' widget to correct position --- .../views/Transfers/AddEditViewTransfer.jsx | 19 ++++++++++++++++++- .../Transfers/components/TransferView.jsx | 12 ++---------- 2 files changed, 20 insertions(+), 11 deletions(-) diff --git a/frontend/src/views/Transfers/AddEditViewTransfer.jsx b/frontend/src/views/Transfers/AddEditViewTransfer.jsx index 2968b16a8..4dec7f977 100644 --- a/frontend/src/views/Transfers/AddEditViewTransfer.jsx +++ b/frontend/src/views/Transfers/AddEditViewTransfer.jsx @@ -7,7 +7,7 @@ import { useNavigate, useParams } from 'react-router-dom' -import { roles } from '@/constants/roles' +import { roles, govRoles } from '@/constants/roles' import { ROUTES } from '@/constants/routes' import { TRANSACTIONS } from '@/constants/routes/routes' import { TRANSFER_STATUSES } from '@/constants/statuses' @@ -47,6 +47,7 @@ import { buttonClusterConfigFn } from './buttonConfigs' import { CategoryCheckbox } from './components/CategoryCheckbox' import { Recommendation } from './components/Recommendation' import SigningAuthority from './components/SigningAuthority' +import InternalComments from '@/components/InternalComments' export const AddEditViewTransfer = () => { const queryClient = useQueryClient() @@ -444,6 +445,22 @@ export const AddEditViewTransfer = () => { )} + {/* Internal Comments */} + {!editorMode && ( + <> + + {transferId && ( + + + + )} + + + )} + {/* Signing Authority Confirmation show it to FromOrg user when in draft and ToOrg when in Sent status */} {(!currentStatus || (currentStatus === TRANSFER_STATUSES.DRAFT && diff --git a/frontend/src/views/Transfers/components/TransferView.jsx b/frontend/src/views/Transfers/components/TransferView.jsx index cd837d0e8..b44013d8f 100644 --- a/frontend/src/views/Transfers/components/TransferView.jsx +++ b/frontend/src/views/Transfers/components/TransferView.jsx @@ -1,7 +1,6 @@ import BCBox from '@/components/BCBox' -import InternalComments from '@/components/InternalComments' -import { Role } from '@/components/Role' -import { roles, govRoles } from '@/constants/roles' + +import { roles } from '@/constants/roles' import { TRANSFER_STATUSES, getAllTerminalTransferStatuses @@ -89,13 +88,6 @@ export const TransferView = ({ transferId, editorMode, transferData }) => { /> )} - {/* Internal Comments */} - - {transferId && ( - - )} - - {/* List of attachments */} {/* */}