Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCFS - Make Fuel type other mandatory when active #1455

Closed
3 tasks
airinggov opened this issue Dec 13, 2024 · 0 comments
Closed
3 tasks

LCFS - Make Fuel type other mandatory when active #1455

airinggov opened this issue Dec 13, 2024 · 0 comments
Assignees
Labels
Compliance Reporting High High priority ticket but not critical at this time Story User story Tested :) Testing passed

Comments

@airinggov
Copy link
Collaborator

airinggov commented Dec 13, 2024

Description:
For both Fuel supply and Export fuel schedules. Update the form validation logic to ensure that when 'Other' is selected from the 'Fuel type' dropdown, the 'Fuel type other' field becomes mandatory and cannot be left blank.

Wireframe:
Image

Purpose and benefit to user:
Enforce accurate data entry by ensuring the 'Fuel type other' field is completed when 'Other' is selected, reducing incomplete or invalid submissions.

Acceptance Criteria:

  1. When 'Other' is selected in the 'Fuel type' dropdown, the 'Fuel type other' field becomes active and is required.
  2. Attempting to submit the form without completing the 'Fuel type other' field triggers an error message: "Fuel type other field is required"
  3. The error message is displayed near the 'Fuel type other' field and follows the application's standard styling.
  4. The form cannot be submitted until the 'Fuel type other' field is completed when 'Other' is selected.

Development Checklist:

  • Update form logic to make 'Fuel type other' mandatory when active ('Fuel type', 'Other' is selected).
  • Add an error message for empty 'Fuel type other' submissions.
  • Test form behavior to confirm validation triggers only when 'Other' is selected.

Notes:

  • Confirm error messaging with the design and content teams for consistency.
@airinggov airinggov added Compliance Reporting High High priority ticket but not critical at this time Story User story labels Dec 13, 2024
@dhaselhan dhaselhan self-assigned this Dec 17, 2024
@Grulin Grulin added the Tested :) Testing passed label Dec 19, 2024
@Grulin Grulin closed this as completed Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compliance Reporting High High priority ticket but not critical at this time Story User story Tested :) Testing passed
Projects
None yet
Development

No branches or pull requests

3 participants