Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCFS - Add a Return report to the supplier button #1507

Open
8 tasks
airinggov opened this issue Dec 19, 2024 · 3 comments
Open
8 tasks

LCFS - Add a Return report to the supplier button #1507

airinggov opened this issue Dec 19, 2024 · 3 comments
Assignees
Labels
Compliance Reporting Medium Medium priority Story User story

Comments

@airinggov
Copy link
Collaborator

airinggov commented Dec 19, 2024

Description:
Add a "Return report to the supplier" button to the bottom of compliance reports in Submitted status. This button will allow returning the report to Draft status. The action will not be tracked in the history, and when the supplier resubmits the report, the original "Sign & Submit" history will update to the new submission date. The button will only be available until March 31 of the current year.

Wireframe: <Return report to supplier mock-up>
Image

Purpose and benefit to user:
This feature allows Analysts to return reports to Draft status for corrections or updates by the supplier.

Acceptance Criteria:

  1. The "Return report to the supplier" button appears only for compliance reports in Submitted status.
  2. Clicking the button changes the report status to Draft.
  3. History does not track this action.
  4. When the supplier resubmits the report, the "Sign & Submit" history is updated to the new submission date.
  5. The button is only available until March 31 of the current year. After this date, the button is disabled or removed.

Development Checklist:

  • Add the "Return report to the supplier" button to the bottom of compliance reports in Submitted status.
  • Implement logic to change the report status to Draft when the button is clicked.
  • Exclude this action from the report history tracking.
  • Delete the "Sign & Submit" history when returned.
  • Discussion comments between Analyst/Manager/Director should be retained.
  • Ensure the button is only visible and functional until March 31 of the current year.
  • Conduct testing to verify the button behavior and ensure no impact on existing submission and history functionality.
  • Add a cypress test to cover this scenario

Notes:

  • Confirm with stakeholders that no additional history entries are required for this action.
  • Ensure the UI for the button aligns with existing design guidelines for action buttons.
  • Test date-based functionality to confirm the button is unavailable after March 31.
@airinggov airinggov added Compliance Reporting Medium Medium priority Story User story labels Dec 19, 2024
@dhaselhan
Copy link
Collaborator

I realized we also create a Reserve transaction when a report is submitted to hold the credits. We will need to delete that as well so we dont double reserve.

@prv-proton prv-proton self-assigned this Dec 19, 2024
@airinggov
Copy link
Collaborator Author

@prv-proton realizing too there may be issues with Summary snapshot data. I think we take a 'snapshot' of the Summary data upon submission. I think we can overwrite the original snapshot with a new snapshot when they re-submit the report.

@prv-proton
Copy link
Collaborator

Instead of snapshot, we'll be unlocking summary for updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compliance Reporting Medium Medium priority Story User story
Projects
None yet
Development

No branches or pull requests

3 participants